Update fields.yml for ECS v1.1.0 #13321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem |
jsoriano
approved these changes
Aug 23, 2019
webmat
approved these changes
Aug 23, 2019
|
Are we having big problems on Jenkins? Let's try to kick it again, just for kicks. jenkins, test this |
This updates the fields.ecs.yml file and the vendored Go code to be based on ECS v1.1.0. Relates elastic#13320
andrewkroh
force-pushed
the
feature/ecs-1-1-0-schema
branch
from
330486e to
f578a59
Compare
webmat
reviewed
Aug 23, 2019
| @@ -20,4 +20,4 @@ | |||
| package ecs | |||
|
|
|||
| // Version is the Elastic Common Schema version from which this was generated. | |||
| const Version = "1.0.1" | |||
| const Version = "1.1.0" | |||
There was a problem hiding this comment.
@andrewkroh Will the events have ecs.version=1.1.0 based on this? Or is there another constant to be changed somewhere?
There was a problem hiding this comment.
I had done a grep for 1.0.1 in libbeat and didn't find anything so it must be using a constant. We can double check this after we have a build.
|
There's a failure in x-pack/metricbeat but it's passing on Jenkins. And on Jenkins all of the Windows workers are failing due to some kind Jenkins problem with archiving artifacts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the fields.ecs.yml file and the vendored Go code to be based on ECS v1.1.0.
Relates #13320