Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up Winlogbeat module fields #13116

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Clean-up Winlogbeat module fields #13116

merged 2 commits into from
Jul 31, 2019

Conversation

andrewkroh
Copy link
Member

  • Add fields.yml files to modules.
  • Add a test to validate all fields in module events are documented.
  • Add missing winlog.user.name to fields.common.yml.
  • Small updates to module docs.

@andrewkroh
Clean-up Winlogbeat module fields
1b7c0ef 
- Add fields.yml files to modules.
- Add a test to validate all fields in module events are documented.
- Add missing winlog.user.name to fields.common.yml.
- Small updates to module docs.
@andrewkroh andrewkroh requested a review from a team as a code owner July 31, 2019 01:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

adriansr
adriansr reviewed Jul 31, 2019
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

x-pack/winlogbeat/module/security/_meta/fields.yml Outdated Show resolved Hide resolved
@andrewkroh andrewkroh merged commit 41a3f86 into elastic:master Jul 31, 2019
@andrewkroh andrewkroh mentioned this pull request Aug 22, 2019
Merged
1 task
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 26, 2019
@andrewkroh
Update Sysmon Event ID 22 for ECS DNS
b448de3 
Change two fields to match ECS DNS. This is a follow-up to elastic#13116 now that the field names are finalized.
andrewkroh added a commit that referenced this pull request Aug 27, 2019
@andrewkroh
Update Sysmon Event ID 22 for ECS DNS (#13323)
88483a8 
Change two fields to match ECS DNS. This is a follow-up to #13116 now that the field names are finalized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
review Winlogbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @elasticmachine @adriansr