WIP Timeline Support #12831
Closed
WIP Timeline Support #12831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 9, 2019
| return rps.next() | ||
| } | ||
|
|
||
| func NewResponsePatternSequence(patterns []*responsePattern, shuffle bool) *responsePatternSequence { |
There was a problem hiding this comment.
exported func NewResponsePatternSequence returns unexported type *main.responsePatternSequence, which can be annoying to use
exported function NewResponsePatternSequence should have comment or be unexported
| func main() { | ||
| states := &sync.Map{} | ||
|
|
||
| var reqs uint64 = 0 |
There was a problem hiding this comment.
should drop = 0 from declaration of var reqs; it is the zero value
houndci-bot
reviewed
Jul 9, 2019
| } | ||
| monitorIdString, _ := monitorId.(string) | ||
| stateTrackerMtx.Lock() | ||
| cssId := stateTracker.getID(monitorIdString, trackerStatus) |
| } else { | ||
| trackerStatus = StatusDown | ||
| } | ||
| monitorIdString, _ := monitorId.(string) |
There was a problem hiding this comment.
var monitorIdString should be monitorIDString
| @@ -177,10 +303,24 @@ func makeAddSummary() jobs.JobWrapper { | |||
|
|
|||
| // After last job | |||
| if state.remaining == 0 { | |||
| monitorId, _ := event.GetValue("monitor.id") | |||
| return state | ||
| } | ||
|
|
||
| func (mst *monitorStateTracker) getID(monitorId string, currentStatus stateStatus) time.Time { |
There was a problem hiding this comment.
method parameter monitorId should be monitorID
| if state.flapCompute(currentStatus) { | ||
| fmt.Printf("STABLE FLAP\n") | ||
| return state | ||
| } else { |
There was a problem hiding this comment.
if block ends with a return statement, so drop this else and outdent its block
| @@ -121,6 +137,116 @@ func addMonitorDuration(job jobs.Job) jobs.Job { | |||
| } | |||
| } | |||
|
|
|||
| const FlappingThreshold time.Duration = time.Minute | |||
There was a problem hiding this comment.
exported const FlappingThreshold should have comment or be unexported
| trackerId := fmt.Sprintf("%s-%s", id, ip) | ||
|
|
||
| stateTrackerMtx.Lock() | ||
| cssId := stateTracker.getID(trackerId, trackerStatus) |
| trackerStatus = StatusUp | ||
| } | ||
| ip, _ := event.Fields.GetValue("monitor.ip") | ||
| trackerId := fmt.Sprintf("%s-%s", id, ip) |
| return rps.next() | ||
| } | ||
|
|
||
| func NewResponsePatternSequence(patterns []*responsePattern, shuffle bool) *responsePatternSequence { |
There was a problem hiding this comment.
exported func NewResponsePatternSequence returns unexported type *main.responsePatternSequence, which can be annoying to use
exported function NewResponsePatternSequence should have comment or be unexported
| func main() { | ||
| states := &sync.Map{} | ||
|
|
||
| var reqs uint64 = 0 |
There was a problem hiding this comment.
should drop = 0 from declaration of var reqs; it is the zero value
andrewvc
added
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime |
Add support for `next_run` and `next_run_in` fields to the monitors object in events. This allows for the computation of SLA statistics in elasticsearch.
houndci-bot
reviewed
Dec 16, 2019
| } | ||
| monitorIdString, _ := monitorId.(string) | ||
| stateTrackerMtx.Lock() | ||
| cssId := statusBlockTracker.getID(monitorIdString, trackerStatus) |
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
@andrewvc Should this PR stay open (no recent activity) or can it be closed? |
|
This pull request does not have a backport label. Could you fix it @andrewvc? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to see here for now