Document Beater Interface / Minor behavioral changes #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/beater
branch
from
35144f2 to
86c8eb3
Compare
|
Maybe add a CHANGELOG update for the |
|
LGTM. |
Add godocs describing how the Beater interface is used. Read YAML configuration file one time (instead of twice) Remove os.Exit calls from Packetbeat Print Config OK to stdout on succesful -configtest. Changed HandleFlags() to return an error Fixes elastic#1234
andrewkroh
force-pushed
the
feature/beater
branch
from
86c8eb3 to
35605b7
Compare
|
@tsg I updated the CHANGELOG file. |
|
@andrewkroh This probably also has to be applied to beat-generator? |
|
@ruflin It should be backward compatible. But yes, there are a few things in the generator that can now be updated, like using |
|
@andrewkroh Yeah. I think it is important that beat-generator is "identical" to the structure we use in our beats. |
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Apr 19, 2016
They were dropped during the refactor in elastic#1249.
ruflin
pushed a commit
that referenced
this pull request
Apr 19, 2016
They were dropped during the refactor in #1249.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add godocs describing how the Beater interface is used.
Read YAML configuration file one time (instead of twice)
Remove
os.Exitcalls from PacketbeatPrint
Config OKto stdout on succesful-configtest.Changed
HandleFlags()to return an errorGuarantee that
Beater.Run()andBeater.Cleanup()are called before the process exits.