Fix 11975 - change Kubernetes container cpu cores fields to float #12476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubernetes.container.cpu.limit.cores is now a float kubernetes.container.cpu.request.cores is now a float
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
exekias
added
bug
needs_backport
|
Thank you for your contribution 🎉 🎉 this is looking good, let's wait for the tests to confirm 😄 jenkins, test this please |
exekias
approved these changes
Jun 7, 2019
|
Thanks for the merge @exekias ! :) |
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this pull request
Jun 12, 2019
…astic#12476) * Fix 11975 kubernetes cores fields data type long -> float (elastic#11975) kubernetes.container.cpu.limit.cores is now a float kubernetes.container.cpu.request.cores is now a float
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Jun 19, 2019
…astic#12476) * Fix 11975 kubernetes cores fields data type long -> float (elastic#11975) kubernetes.container.cpu.limit.cores is now a float kubernetes.container.cpu.request.cores is now a float (cherry picked from commit 8502c79)
exekias
added
v7.2.0
and removed
needs_backport
exekias
pushed a commit
that referenced
this pull request
Jun 20, 2019
…u cores fields to float (#12609) * Fix 11975 - change Kubernetes container cpu cores fields to float (#12476) * Fix 11975 kubernetes cores fields data type long -> float (#11975) kubernetes.container.cpu.limit.cores is now a float kubernetes.container.cpu.request.cores is now a float (cherry picked from commit 8502c79) * Update CHANGELOG.next.asciidoc
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…iner cpu cores fields to float (elastic#12609) * Fix 11975 - change Kubernetes container cpu cores fields to float (elastic#12476) * Fix 11975 kubernetes cores fields data type long -> float (elastic#11975) kubernetes.container.cpu.limit.cores is now a float kubernetes.container.cpu.request.cores is now a float (cherry picked from commit d8eb8e8) * Update CHANGELOG.next.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #11975 where it's reported that the
kubernetes.container.cpu.limit.coresandkubernetes.container.cpu.requests.coresfields should be floats instead of longs.This is my first contribution, so please let me know if I've missed anything.
make updatehas been run and the result committed. If there are other fields that need to be changed along the same lines, I'd be grateful if someone could clue me in.Thanks in advance for your time :)