Export Kibana Client's Transport and Version #12422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required to mock a Kibana connection outside its own package
houndci-bot
reviewed
Jun 4, 2019
libbeat/kibana/client.go
Outdated
| @@ -41,8 +41,8 @@ type Connection struct { | |||
| Username string | |||
| Password string | |||
|
|
|||
| http *http.Client | |||
| version common.Version | |||
| Http *http.Client | |||
There was a problem hiding this comment.
@jalvz I guess we could satisfy this?
There was a problem hiding this comment.
ofc! - sorry for delay, was holiday
ph
approved these changes
Jun 6, 2019
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this pull request
Jun 12, 2019
Required to mock a Kibana connection outside its own package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #12266
I was thinking that implementing the RounTripper interface would be enough, but forgot to export the transport object, which is required to mock a Kibana connection outside its own package.
Also need to export the Version.
Use case here: elastic/apm-server@e6bbb20#diff-7abfb8887df4c4f059976f3d276ed9ebR37