Cherry-pick #12125 to 6.8: Fix goroutine leak on initialization failures of log input #12144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
force-pushed
the
backport_12125_6.8
branch
from
4750a96 to
f870930
Compare
exekias
approved these changes
May 10, 2019
|
jenkins, test this again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12125 to 6.8 branch. Original message:
Detected on #12106, possibly related to #9302.
These outlets should be probably created on
Run(), but itcannot return an error. I'd fix it like this by now,
and would do further refactors on future PRs.