Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filebeat envoyproxy module #11700

Merged
merged 22 commits into from
Apr 17, 2019
Merged

Filebeat envoyproxy module #11700

merged 22 commits into from
Apr 17, 2019

Conversation

alakahakai
Copy link

@alakahakai alakahakai commented Apr 8, 2019 •
edited
Loading

Filebeat envoyproxy module:

  • Handles both Kubernetes deployment and native deployment scenarios
  • Supports both HTTP and TCP outputs

@alakahakai alakahakai requested review from a team as code owners April 8, 2019 17:03
@alakahakai alakahakai added Filebeat Filebeat module in progress Pull request is currently in progress. labels Apr 8, 2019
@alakahakai alakahakai requested a review from a team April 8, 2019 17:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@alakahakai
Copy link
Author

jenkins, test this

@alakahakai alakahakai added review and removed in progress Pull request is currently in progress. labels Apr 12, 2019
@alakahakai
Copy link
Author

jenkins, test this

1 similar comment
@alakahakai
Copy link
Author

jenkins, test this

andrewkroh
andrewkroh approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor comments.

x-pack/filebeat/module/envoyproxy/_meta/docs.asciidoc Outdated Show resolved Hide resolved
@alakahakai alakahakai merged commit 03e316e into elastic:master Apr 17, 2019
@alakahakai alakahakai deleted the filebeat-envoy branch April 18, 2019 16:58
@tsg tsg added needs_backport PR is waiting to be backported to other branches. and removed needs_backport PR is waiting to be backported to other branches. labels Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odacremolbap odacremolbap odacremolbap left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

@tsg tsg Awaiting requested review from tsg

Assignees
No one assigned
Labels
Filebeat Filebeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alakahakai @elasticmachine @andrewkroh @odacremolbap @tsg