Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 6.x content from breaking changes #11674

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

dedemorton
Copy link
Contributor

Removing 6.x breaking changes. For earlier releases, we only provide breaking changes for the major version. Users can use the version selector to see BCs for earlier releases.

Needs backport to 7.0

@dedemorton dedemorton added docs review needs_backport PR is waiting to be backported to other branches. labels Apr 5, 2019
@dedemorton dedemorton requested a review from a team as a code owner April 5, 2019 18:50
@urso
Copy link

urso commented Apr 7, 2019

I'm not sure if we really should remove these. 5.6 goes EOL and we may have users upgrading from 5.x or older 6.x version to 7.0 (via 6.7 I hope).

@dedemorton
Copy link
Contributor Author

dedemorton commented Apr 9, 2019

@urso Having the 6.x BCs in the 7.x documentation breaks the model that we've used in the past and is not consistent with how other products are doing their breaking changes. I realize we already do that with the release notes by providing all the things, but showing 6.x breaking changes in the 7.x docs departs from what we've done in the past for major releases.

@dedemorton dedemorton merged commit ecae0a9 into elastic:master Apr 15, 2019
@dedemorton dedemorton deleted the remove_6.x_BCs branch April 15, 2019 22:04
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 15, 2019
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 15, 2019
dedemorton added a commit that referenced this pull request Apr 16, 2019
…1832)

* Remove 6.x content from breaking changes (#11674)

* Use 6.0 attribute to resolve path to breaking changes (#11831)
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants