[Metricbeat] migrate golang module to ReporterV2 error #11382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
Metricbeat
ruflin
approved these changes
Mar 22, 2019
| logger.Error(err) | ||
| reporter.Error(err) | ||
| return | ||
| return errors.Wrap(err, "Error in http fetch") |
There was a problem hiding this comment.
Nit: errors inside errors should start lower case. I wonder why Hound did not complain.
There was a problem hiding this comment.
Oddly enough, the linter I have in vscode usually complains about that as well. Might be more context-dependent?
93 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11374 and #10727
This was @ruflin and my idea, now that we have a "cleaner" error interface that could potentially remove some boilerplate from
Fetch().We also decided to do this on a module-by-module basis where possible, to avoid spamming with excessive PRs, as each change is rather small. However I'm not set on this, and we could do it metricset-by-metricset if people prefer.