Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #11296 to 7.0: Check license x-pack #11342

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Conversation

ph
Copy link
Contributor

@ph ph commented Mar 20, 2019

Cherry-pick of PR #11296 to 7.0 branch. Original message:

Early look on the way of doing it.

This strategy has some limitations, we cannot set a specific license for a specific call but for the current need, I think it's OK.

I am currently in the process or splittings the Elasticsearch output module into a pipeline client an elasticsearch client, I will try to revisit the strategy there.

Note: I've tried to use the normal callbacks, but I've decided against for two reasons:

  • Callback execution does not respect the insertion order.
  • Pipeline clients and load pipelines doesn't use the same part so they don't respect configured callbacks.

I am writing test but I wanted to have an early look.

* Check License for basic or better



(cherry picked from commit b0a2eb4)
@ph ph requested a review from a team as a code owner March 20, 2019 14:48
@ph ph closed this Mar 20, 2019
@ph ph reopened this Mar 20, 2019
@ph ph requested a review from tsg March 20, 2019 14:55
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Testing looks good.

@ph
Copy link
Contributor Author

ph commented Mar 20, 2019

Merging and created #11354 for the redis failure.

@ph ph merged commit f0ba5d6 into elastic:7.0 Mar 20, 2019
@ph ph deleted the backport_11296_7.0 branch March 20, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants