Adding categorization fields for the system/auth module #11334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the following fields for the SSH login events: * `event.category: authentication` * `event.action: ssh_login` * `event.type` either `authentication_success` or `authentication_failure` The `event.outcome` is currently not quite ECS compliant, but I didn't touch it to avoid a breaking change. The PR doesn't attempt to categorize other logs besides the SSH login attempts, so it's a subset of elastic#9905, but it's what we need for the UI.
|
Pinging @elastic/secops |
|
@tsg Do you want to add a changelog? Not sure if we release this already in beta1? |
|
Changelog pushed, will only wait for intake for this one since it was fully green before the changelog change. |
tsg
added a commit
to tsg/beats
that referenced
this pull request
Mar 21, 2019
* Adding categorization fields for the system/auth module This PR adds the following fields for the SSH login events: * `event.category: authentication` * `event.action: ssh_login` * `event.type` either `authentication_success` or `authentication_failure` The `event.outcome` is currently not quite ECS compliant, but I didn't touch it to avoid a breaking change. The PR doesn't attempt to categorize other logs besides the SSH login attempts, so it's a subset of elastic#9905, but it's what we need for the UI. * Normalized event.outcome and brought back `system.auth.ssh.event`. * changelog (cherry picked from commit a9f567b)
tsg
added
v7.0.0
and removed
needs_backport
tsg
added a commit
that referenced
this pull request
Mar 21, 2019
…m/auth module (#11363) * Adding categorization fields for the system/auth module (#11334) * Adding categorization fields for the system/auth module This PR adds the following fields for the SSH login events: * `event.category: authentication` * `event.action: ssh_login` * `event.type` either `authentication_success` or `authentication_failure` The `event.outcome` is currently not quite ECS compliant, but I didn't touch it to avoid a breaking change. The PR doesn't attempt to categorize other logs besides the SSH login attempts, so it's a subset of #9905, but it's what we need for the UI. * Normalized event.outcome and brought back `system.auth.ssh.event`. * changelog (cherry picked from commit a9f567b) * cleanup changelog
webmat
pushed a commit
to webmat/beats
that referenced
this pull request
Mar 28, 2019
- This adds the missing nginx field alias - This also introduces an update introduced in elastic#11334
ruflin
pushed a commit
that referenced
this pull request
Mar 29, 2019
- It was missing in the breaking changes doc (generated from ecs-migration.yml) - The actual field alias was incorrectly pointing to source.ip, this has been adjusted to source.address - Re-generating the documentation file also updated the breaking changes to include a change introduced in #11334 This should be backported to 7.0. Closes #11510
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Mar 29, 2019
- It was missing in the breaking changes doc (generated from ecs-migration.yml) - The actual field alias was incorrectly pointing to source.ip, this has been adjusted to source.address - Re-generating the documentation file also updated the breaking changes to include a change introduced in elastic#11334 This should be backported to 7.0. Closes elastic#11510 (cherry picked from commit 692ef9e)
ruflin
added a commit
that referenced
this pull request
Mar 29, 2019
- It was missing in the breaking changes doc (generated from ecs-migration.yml) - The actual field alias was incorrectly pointing to source.ip, this has been adjusted to source.address - Re-generating the documentation file also updated the breaking changes to include a change introduced in #11334 This should be backported to 7.0. Closes #11510 (cherry picked from commit 692ef9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following fields for the SSH login events:
event.category: authenticationevent.action: ssh_loginevent.typeeitherauthentication_successorauthentication_failureevent.outcomewithersuccessorfailureThis PR also brings back the
system.auth.ssh.eventfield, as we had it in 6.x. This removes a migration.The PR doesn't attempt to categorize other logs beside the SSH login attempts,
so it's a subset of #9905, but it's what we need for the UI.