Cherry-pick #11247 to 7.0: Don't collect empty ip addresses in docker container metricset #11293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic#11247) Docker containers can have empty ip addresses if they are running in host network mode or if they are stopped. Collecting lists with empty addresses can make type mapping to fail when trying to store them as ip addresses. Fix elastic#11225 (cherry picked from commit 258c1c8)
ruflin
suggested changes
Mar 19, 2019
| @@ -72,6 +72,9 @@ https://github.com/elastic/beats/compare/v7.0.0-beta1...master[Check the HEAD di | |||
| - Fix errors in filebeat Zeek dashboard and README files. Add notice.log support. {pull}10916[10916] | |||
| - Fix a bug when converting NetFlow fields to snake_case. {pull}10950[10950] | |||
| - Add on_failure handler for Zeek ingest pipelines. Fix one field name error for notice and add an additional test | |||
| - Add on_failure handler for Zeek ingest pipelines. Fix one field name error for notice and add an additional test case. {issue}11004[11004] {pull}11105[11105] | |||
There was a problem hiding this comment.
Seems to be too much in here?
ruflin
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #11247 to 7.0 branch. Original message:
Docker containers can have empty ip addresses if they are running in
host network mode or if they are stopped. Collecting lists with empty
addresses can make type mapping to fail when trying to store them as ip
addresses.
It only affects 7.0 because before these ip addresses were of type
keyword.Fix #11225