Add on_failure handler for Zeek ingest pipelines. Fix one field name #11105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alakahakai
commented
Mar 6, 2019
alakahakai
commented
- Address issue 11004 - Add on_failure handler for Zeek ingest pipelines.
- Fix one field name error for notice and add an additional test
…error for notice and add an additional test
|
Pinging @elastic/secops |
webmat
reviewed
Mar 6, 2019
CHANGELOG.next.asciidoc
Outdated
| @@ -161,6 +161,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Improve detection of file deletion on Windows. {pull}10747[10747] | |||
| - Fix errors in filebeat Zeek dashboard and README files. Add notice.log support. {pull}10916[10916] | |||
| - Fix a bug when converting NetFlow fields to snake_case. {pull}10950[10950] | |||
| - Add on_failure handler for Zeek ingest pipelines. Fix one field name error for notice and add an additional test | |||
| case. {{issue}11004[11004] pull}11105[11105] | |||
There was a problem hiding this comment.
Check out your asciidoc links here ;-)
There was a problem hiding this comment.
Suggested change
| case. {{issue}11004[11004] pull}11105[11105] | |
| case. {issue}11004[11004] {pull}11105[11105] |
| @@ -0,0 +1,21 @@ | |||
| # Module: zeek | |||
| # Docs: https://www.elastic.co/guide/en/beats/filebeat/master/filebeat-module-zeek.html | |||
There was a problem hiding this comment.
Should we use /current/ instead of /master/ here?
There was a problem hiding this comment.
I think these headers are generated based on the documentation branch which is master so this is correct.
andrewkroh
approved these changes
Mar 6, 2019
| @@ -0,0 +1,21 @@ | |||
| # Module: zeek | |||
| # Docs: https://www.elastic.co/guide/en/beats/filebeat/master/filebeat-module-zeek.html | |||
There was a problem hiding this comment.
I think these headers are generated based on the documentation branch which is master so this is correct.
CHANGELOG.next.asciidoc
Outdated
| @@ -161,6 +161,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Improve detection of file deletion on Windows. {pull}10747[10747] | |||
| - Fix errors in filebeat Zeek dashboard and README files. Add notice.log support. {pull}10916[10916] | |||
| - Fix a bug when converting NetFlow fields to snake_case. {pull}10950[10950] | |||
| - Add on_failure handler for Zeek ingest pipelines. Fix one field name error for notice and add an additional test | |||
| case. {{issue}11004[11004] pull}11105[11105] | |||
There was a problem hiding this comment.
Suggested change
| case. {{issue}11004[11004] pull}11105[11105] | |
| case. {issue}11004[11004] {pull}11105[11105] |
This was referenced Mar 7, 2019
alakahakai
pushed a commit
that referenced
this pull request
Mar 12, 2019
monicasarbu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.