Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing host.* fields to fields.yml #11016

Merged
merged 5 commits into from
Mar 4, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Mar 1, 2019

The add_host_metadata processor (default since 6.5) fills the fields host.os.build and host.containerized, but there is no entry for them in fields.yml so they are missing from the generated index patterns.

This adds them to add_host_metadata/_meta/fields.yml.

#10992 already addressed this for 6.7.

Christoph Wurm added 2 commits March 1, 2019 12:29
@cwurm cwurm added the review label Mar 1, 2019
@cwurm cwurm requested review from a team as code owners March 1, 2019 12:42
@webmat webmat added the ecs label Mar 1, 2019
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object to adding these fields to Beats, however neither of these fields is defined in ECS. So please add them to fields.common.yml.

Alternately, the source of the event could populate host.os.version instead, with the full version string.

I must say containerized doesn't have a clear mapping in ECS, though. I'm making a note to look into this.

@cwurm cwurm force-pushed the missing_host_fields branch from 1caec73 to ab0a4f9 Compare March 1, 2019 21:04
@cwurm
Copy link
Contributor Author

cwurm commented Mar 1, 2019

@webmat To be clear, these fields are currently produced by all Beats by default since the add_host_metadata processor was added to the default config in 6.5. Even before, these fields were presumably (I didn't check) produced when the processor was enabled.

I might have dodged a bullet here. I was afraid I'd have to invent a new top-level key with an accompanying "Exported fields" docs section. But luckily, we already have a "Host fields" section that is currently empty (e.g. here) that I've now re-used. Let me know what you think of this solution.

Eventually, we might need a top-level section for non-ECS fields common to all Beats. The existing "Common" sections are Beat-specific, unfortunately.

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

I had in mind libbeat/_meta/fields.common.yml, but I think this specific processor's field defs is even better 👍

@cwurm cwurm merged commit 091a673 into elastic:master Mar 4, 2019
@cwurm cwurm deleted the missing_host_fields branch March 4, 2019 12:54
@cwurm cwurm added the v7.2.0 label Mar 4, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Mar 4, 2019
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns.

This adds them to `add_host_metadata/_meta/fields.yml`.

elastic#10992 already addressed this for 6.7.
(cherry picked from commit 091a673)
@cwurm cwurm added the v7.0.0 label Mar 4, 2019
cwurm pushed a commit that referenced this pull request Mar 5, 2019
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns.

This adds them to `add_host_metadata/_meta/fields.yml`.

#10992 already addressed this for 6.7.
(cherry picked from commit 091a673)
cwurm pushed a commit to cwurm/beats that referenced this pull request Mar 5, 2019
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns.

This adds them to `add_host_metadata/_meta/fields.yml`.

elastic#10992 already addressed this for 6.7.
(cherry picked from commit 091a673)
cwurm pushed a commit that referenced this pull request Mar 5, 2019
…11061)

Cherry-pick of PR #11016 to 7.x branch. Original message: 

The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns.

This adds them to `add_host_metadata/_meta/fields.yml`.

#10992 already addressed this for 6.7.
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns.

This adds them to `add_host_metadata/_meta/fields.yml`.

elastic#10992 already addressed this for 6.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants