-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing host.* fields to fields.yml #11016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't object to adding these fields to Beats, however neither of these fields is defined in ECS. So please add them to fields.common.yml
.
Alternately, the source of the event could populate host.os.version
instead, with the full version string.
I must say containerized
doesn't have a clear mapping in ECS, though. I'm making a note to look into this.
1caec73
to
ab0a4f9
Compare
@webmat To be clear, these fields are currently produced by all Beats by default since the I might have dodged a bullet here. I was afraid I'd have to invent a new top-level Eventually, we might need a top-level section for non-ECS fields common to all Beats. The existing "Common" sections are Beat-specific, unfortunately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change!
I had in mind libbeat/_meta/fields.common.yml
, but I think this specific processor's field defs is even better 👍
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns. This adds them to `add_host_metadata/_meta/fields.yml`. elastic#10992 already addressed this for 6.7. (cherry picked from commit 091a673)
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns. This adds them to `add_host_metadata/_meta/fields.yml`. #10992 already addressed this for 6.7. (cherry picked from commit 091a673)
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns. This adds them to `add_host_metadata/_meta/fields.yml`. elastic#10992 already addressed this for 6.7. (cherry picked from commit 091a673)
…11061) Cherry-pick of PR #11016 to 7.x branch. Original message: The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns. This adds them to `add_host_metadata/_meta/fields.yml`. #10992 already addressed this for 6.7.
The `add_host_metadata` processor (default since 6.5) fills the fields `host.os.build` and `host.containerized`, but there is no entry for them in `fields.yml` so they are missing from the generated index patterns. This adds them to `add_host_metadata/_meta/fields.yml`. elastic#10992 already addressed this for 6.7.
The
add_host_metadata
processor (default since 6.5) fills the fieldshost.os.build
andhost.containerized
, but there is no entry for them infields.yml
so they are missing from the generated index patterns.This adds them to
add_host_metadata/_meta/fields.yml
.#10992 already addressed this for 6.7.