Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize test_input_pipeline_config #10822

Closed

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 19, 2019

test_input_pipeline_config has been unstable due to too many dynamic scripts executions when uploading the test pipeline. As this pipeline is super primitive, it is highly unlikely that it causes the issue. However, when a new pipeline is uploaded all of those are reloaded on all nodes, so it is possible that an existing pipeline creates the problem. To avoid this, all existing pipelines are deleted while the test is being run. When the test terminates, pipelines are uploaded again not to mess up the existing environment.

This PR only stabilises the test. But the issue still needs an investigation to see which pipeline leads to too many script executions. To make debugging a bit easier, I have added a debug print to see which pipeline fails when the problem resurfaces.

Closes #9587
Closes #9600

@kvch kvch added review Filebeat Filebeat labels Feb 19, 2019
@kvch kvch requested a review from a team as a code owner February 19, 2019 13:27
@kvch kvch removed the request for review from a team February 19, 2019 13:28
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let keep an eye out to find that pipeline!

@kvch
Copy link
Contributor Author

kvch commented Mar 4, 2019

I put this PR on hold to come up with a solution for running these tests in parallel. As I am deleting the pipelines for a time being, it's possible if other tests require those pipelines, they will fail

@urso
Copy link

urso commented Apr 15, 2019

@kvch what is the state of this PR? Can we merge it?

@andrewkroh
Copy link
Member

We haven't seen test_input_pipeline_config show up in the build stats for a while so this might be stable now.

@kvch kvch closed this Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants