Cherry-pick to 7.0: Add username password into kibana config (#10675) #10702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Turned out the fix in #10553 won't solve the issue because
kibana.NewKibanaClient(kibanaConfig)is called beforedashboards.ImportDashboards, which already requires the correct config including password and username as input. So moving the same code upfront beforekibana.NewKibanaClientis called solves this issue.Add username password into kibana config before calling NewKibanaClient
Add changelog
Add unit test for initKibanaConfig
Run make fmt
Add comment on initKibanaConfig
(cherry picked from commit 5d280da)