Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.name as an option to all Metricbeat modules #10427

Merged
merged 4 commits into from
Feb 1, 2019

Conversation

jsoriano
Copy link
Member

Add an option to set service.name in all Metricbeat modules.
This option doesn't override the value in the event if it has been
already set by the metricset.

@jsoriano jsoriano self-assigned this Jan 30, 2019
@jsoriano jsoriano requested a review from ruflin January 30, 2019 12:00
@jsoriano jsoriano requested a review from a team as a code owner January 30, 2019 12:00
@jsoriano jsoriano requested a review from andrewkroh January 30, 2019 12:10
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation.

@jsoriano jsoriano added the review label Feb 1, 2019
@jsoriano jsoriano merged commit 3813452 into elastic:master Feb 1, 2019
@jsoriano jsoriano deleted the mb-service-name branch February 1, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants