-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Replace Suricata/Eve fields with aliases to ECS fields #10377
Merged
adriansr
merged 10 commits into
elastic:master
from
adriansr:feature_suricata_ecs_aliases
Jan 29, 2019
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
84fbe13
Reformat ingest pipeline
adriansr 6d57056
Alias suricata fields to point to ECS counterparts
adriansr 312ac43
Update fields docs
adriansr 1e2af11
Dashboards use ECS fields
adriansr 163013b
Restore suricata.eve.alert.category
adriansr 4476225
Regenerate golden files
adriansr 4331bf9
Replace convert,delete pairs with renames in pipeline
adriansr 7246103
Add aliases to ecs-migration file
adriansr 08f9092
Add alias for suricata.eve.http.url to url.original
adriansr 073e1de
Fix suricata.eve.http.http_refer
adriansr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For most of these fields, you could actually get rid of the
convert { type: string}
and do a straight field rename. Would look much more like the other modules, and would remove the need to have this hugeremove
operation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are completely right. There's a lot of cleanup that can be done