-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] List of text fields to be converted #10372
Conversation
This PR is for discussing the current text fields in Filebeat and if the type should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've turned up a lot of things, good stuff!
I think when in doubt, we should always go for keyword
indexing at the canonical field (or go for non-indexed if really it doesn't make sense to index); and leave users or future us add .text
later on, when needed. This new convention reduces chances of breaking changes a lot, for all fields where we adopt it.
Tried to respond to everything below :-)
Probably a question for @ruflin: In many ECS conversion PRs we say we want to treat a field as |
@ycombinator Yes:
|
@ycombinator Could you tackle the Stack modules changes? |
I opened PR for all changes except the Elastic Stack. @ycombinator Can you ping here as soon as you have 1 (or multiple PR's) open for the fields so I can close this PR here? |
@ruflin will do, it's item 5 on my TODO list for today so will probably get to it in a couple hours unless other stuff pops up (which never happens, of course). |
@ruflin @webmat I've opened 2 PRs for the stack module changes:
|
Thanks @ycombinator Closing this PR as all changes have been addressed in follow up PR's. |
This PR is an offshoot of conversations and decisions made in #10372 w.r.t `text` fields, but scoped to the `logstash` module.
This PR is an offshoot of conversations and decisions made in #10372 w.r.t `text` fields, but scoped to the `elasticsearch` module.
This PR is for discussing the current text fields in Filebeat and if the type should be changed.