-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace read_timestamp with event.created in all remaining Filebeat modules #10139
Conversation
Test failures are related:
For Kibana, Redis and Kafka |
@ycombinator In migrating |
Thanks for fixing up the Kibana pipeline, @webmat! Would it be worth adding a special mention about this breaking change in the CHANGELOG? |
- iis.error - nginx.access - osquery - traefik.access
- read_timestamp can be aliased in 6.x for forward compatibility - it was present twice in the file, now only present once at the beginning, with other common fields
Will modify both entries to identify the only two beats affected, instead. This reverts commit 4ee063a3cd5755d773822fa83a4cf1fda04f1441.
@ycombinator Oh yes, good point. I've done that. Hopefully not too verbose. |
…astic#10139) Note that some of the recent module migrations have already started populating `event.created` instead of `read_timestamp`. This PR finishes this work all at once. - Replace `read_timestamp` with `event.created` in remaining Fb modules: - iis.error - kafka - kibana - nginx.access - osquery - redis - traefik.access - No longer excluding `read_timestamp` from integration test results, as it's no longer expected - Finish equivalent migration in Journalbeat by making `read_timestamp` into an alias - Adjust Kibana module's pipeline to use the correct semantics for `event.created`
Note that some of the recent module migrations have already started populating
event.created
instead ofread_timestamp
. This PR does the remaining modules all at once.Modules/filesets affected:
Outside of these modules, the only occurrences I see of
read_timestamp
are the field definitions and test_modules.py.So this PR will alias
read_timestamp
toevent.created
as well.I've taken the opportunity to put in place the alias for Journalbeat as well. Didn't look like it was being used there anymore.