Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL Metricbeat module do not close db connection #9415

Closed
sayden opened this issue Dec 6, 2018 · 1 comment
Closed

MySQL Metricbeat module do not close db connection #9415

sayden opened this issue Dec 6, 2018 · 1 comment
Labels
bug good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat

Comments

@sayden
Copy link
Contributor

sayden commented Dec 6, 2018

The MySQL metricbeat module opens a connection to the database here https://github.com/elastic/beats/blob/master/metricbeat/module/mysql/mysql.go#L103

It seems that the Close() call is not being done as needed by the Golang sql driver https://golang.org/pkg/database/sql/driver/#Conn
@sayden sayden added bug Metricbeat Metricbeat good first issue Indicates a good issue for first-time contributors labels Dec 6, 2018
@sayden sayden changed the title MySQL Metricbeat module do to not close db connection MySQL Metricbeat module do not close db connection Dec 6, 2018
@cachedout cachedout mentioned this issue Dec 8, 2018
Closed
@jarrocha jarrocha mentioned this issue Jan 27, 2019
Merged
@andrewkroh
Copy link
Member

Fixed by #10355.

jsoriano pushed a commit to jsoriano/beats that referenced this issue Jan 29, 2019
@jarrocha @jsoriano
Close mysql connections when stopping mysql metricsets (elastic#10355)
63732e9 
Fixes elastic#9415 by closing the db handle.

(cherry picked from commit f06cf46)
@jsoriano jsoriano mentioned this issue Jan 29, 2019
Merged
jsoriano added a commit that referenced this issue Jan 30, 2019
@jsoriano @jarrocha
Close mysql connections when stopping mysql metricsets (#10355) (#10394)
8b235a9 
Fixes #9415 by closing the db handle.

(cherry picked from commit f06cf46)

Co-authored-by: Jaime A <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close MySQL connections in MetricBeat cachedout/beats
2 participants
@sayden @andrewkroh