Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back to goformation original repository #8857

Closed
ph opened this issue Oct 31, 2018 · 4 comments · Fixed by #15275
Closed

Move back to goformation original repository #8857

ph opened this issue Oct 31, 2018 · 4 comments · Fixed by #15275
Labels
Functionbeat Team:Integrations Label for the Integrations team

Comments

@ph
Copy link
Contributor

ph commented Oct 31, 2018

Because of some compiler issues on windows with the long filename use in the goformation library. We are currently using our own fork to make the compiler works on windows.

Upstream issue at awslabs/goformation#138
@ph ph self-assigned this Oct 31, 2018
@ph ph mentioned this issue Oct 31, 2018
Merged
@andrewkroh
Copy link
Member

andrewkroh commented Nov 1, 2018 •
edited
Loading

Will your changes to jenkins_ci.ps1 allow us to move back to the upstream version?

edit: I see you close that PR.

@ph
Copy link
Contributor Author

ph commented Nov 1, 2018 via email

ph added a commit that referenced this issue Nov 1, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (#8859)
2423c65 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib #8857
ph added a commit to ph/beats that referenced this issue Nov 1, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (elastic#8859)
57a782b 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib elastic#8857

(cherry picked from commit 2423c65)
@ph ph mentioned this issue Nov 1, 2018
Merged
ph added a commit to ph/beats that referenced this issue Nov 1, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (elastic#8859)
be2165a 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib elastic#8857

(cherry picked from commit 2423c65)
@ph ph mentioned this issue Nov 1, 2018
Merged
ph added a commit that referenced this issue Nov 2, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (#8859) (#8881)
9b6cf08 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib #8857

(cherry picked from commit 2423c65)
ph added a commit that referenced this issue Nov 2, 2018
@ph
Use a goformation fork to go around MAX_PATH limitation (#8859) (#8882)
0920cc2 
The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib #8857

(cherry picked from commit 2423c65)
@ph ph mentioned this issue Nov 9, 2018
Closed
29 tasks
@ph ph removed their assignment Dec 20, 2019
@ph
Copy link
Contributor Author

ph commented Dec 20, 2019

@kvch Since you are upgrading some libraries we could also upgrade the goformation sdk they have fixed the windows issues so could depend on the official repository instead of my fork.

@ph ph added the Team:Beats label Dec 20, 2019
@kvch
Copy link
Contributor

kvch commented Dec 23, 2019

I updated the PR: #15231

@kvch kvch mentioned this issue Dec 31, 2019
Merged
kvch added a commit that referenced this issue Dec 31, 2019
@kvch
Update github.com/awslabs/goformation to v4.1.0 (#15275)
d606d38 
This PR updates Functionbeat to use the upstream version of goformation. These changes are missing from the previous updater PR.

Closes #8857
kvch added a commit to kvch/beats that referenced this issue Dec 31, 2019
@kvch
Update github.com/awslabs/goformation to v4.1.0 (elastic#15275)
15413b9 
This PR updates Functionbeat to use the upstream version of goformation. These changes are missing from the previous updater PR.

Closes elastic#8857
(cherry picked from commit d606d38)
@kvch kvch mentioned this issue Dec 31, 2019
Merged
kvch added a commit that referenced this issue Dec 31, 2019
@kvch
Update github.com/awslabs/goformation to v4.1.0 (#15275) (#15281)
1d6cc8c 
This PR updates Functionbeat to use the upstream version of goformation. These changes are missing from the previous updater PR.

Closes #8857
(cherry picked from commit d606d38)
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@ph
Use a goformation fork to go around MAX_PATH limitation (elastic#8859) (
d78bd75 
elastic#8882)

The goformation library is pretty liberal with the lenght of the file it uses, this seems to mess up our windows CI because we reach the MAX_PATH limit.


Followup issue for moving back to original lib elastic#8857

(cherry picked from commit 9a4f572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Functionbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update github.com/awslabs/goformation to v4.1.0 kvch/beats
4 participants
@ph @andresrc @kvch @andrewkroh