http parser should not buffer the complete request and response in memory #6679
Labels
Comments
adriansr
added a commit
to adriansr/beats
that referenced
this issue
Apr 5, 2018
This patch updates the http protocol parser in packetbeat to not buffer the full request/response. Body is only buffered when neccesary, i.e. the `include_body_for` option specifies that the body should be included in the event, or a request body of type form-urlencoded is sent. Fixes elastic#6679
urso
pushed a commit
that referenced
this issue
Apr 5, 2018
* HTTP benchmark for large bodies A simple benchmark that processes a 10MB request. * http: improve hide secrets unit test It would not catch the case where the functionality to extract form-urlencoded parameters is broken. * http: add missing unit tests Tests were missing for the following features: - include_body_for - send_request - send_response * http: remove unused parser state * Reduce memory usage of http parser This patch updates the http protocol parser in packetbeat to not buffer the full request/response. Body is only buffered when neccesary, i.e. the `include_body_for` option specifies that the body should be included in the event, or a request body of type form-urlencoded is sent. Fixes #6679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Users have reported that the performance of packetbeat is poor when dealing with HTTP requests and responses with large bodies.
After a quick analysis of the HTTP parser it has been identified the case where the parser keeps the whole request and response (including bodies) in memory, even when it is not necessary.
The text was updated successfully, but these errors were encountered: