Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CRI logs format #5630

Closed
exekias opened this issue Nov 17, 2017 · 2 comments
Closed

Add support for CRI logs format #5630

exekias opened this issue Nov 17, 2017 · 2 comments
Labels
enhancement Filebeat Filebeat good first issue Indicates a good issue for first-time contributors

Comments

@exekias
Copy link
Contributor

exekias commented Nov 17, 2017 •
edited
Loading

Container Runtime Interface (CRI) initiative standardizes an API for container implementations. It defines its own format for logs, compatible with Docker json-file, but with an alternative implementation (no JSON).

We should update our Docker prospector to support that format, probably we can do autodetection just by checking first chars.

Example log line:

2017-09-12T22:32:21.212861448+00:00 stdout 2017-09-12 22:32:21.212 [INFO][88] table.go 710: Invalidating dataplane cache ipVersion=0x4 reason="refresh timer" table="nat"

CRI-o project: https://github.com/kubernetes-incubator/cri-o
CRI-o code writing logs: https://github.com/mrunalp/cri-o/blob/37e282a29b84ca12b594cc55767295f37da848ea/conmon/conmon.c#L290-L407
@exekias exekias added enhancement Filebeat Filebeat good first issue Indicates a good issue for first-time contributors labels Nov 17, 2017
@exekias exekias changed the title Add support to CRI logs format Add support for CRI logs format Nov 17, 2017
@ruflin
Copy link
Contributor

ruflin commented Nov 20, 2017

@exekias Good idea. We should have it available as autodiscovery or config option.

jreyeshdez pushed a commit to jreyeshdez/beats that referenced this issue Jan 25, 2018
Adds support for CRI logs format.
fe38628 
Created tests for specific CRI logs.
Autodiscovers by looking at first char and it will invoke CRI or Docker log parser depending on it.
Solution for elastic#5630
@jreyeshdez jreyeshdez mentioned this issue Jan 25, 2018
Merged
exekias pushed a commit that referenced this issue Jan 26, 2018
@jreyeshdez @exekias
Add support for CRI logs format (#6181)
6023701 
Adds support for CRI logs format.
Autodiscovers by looking at first char and it will invoke CRI or Docker log parser depending on it.
Solution for #5630
@exekias
Copy link
Contributor Author

exekias commented Jan 29, 2018

Closed by #6181

@exekias exekias closed this as completed Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Filebeat Filebeat good first issue Indicates a good issue for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ruflin @exekias