Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Excluding bind mounts #3384

Closed
abraxxa opened this issue Jan 16, 2017 · 4 comments
Closed

[Metricbeat] Excluding bind mounts #3384

abraxxa opened this issue Jan 16, 2017 · 4 comments
Assignees
@jsoriano
Labels
enhancement Metricbeat Metricbeat module

Comments

@abraxxa
Copy link

abraxxa commented Jan 16, 2017

Feature request per https://discuss.elastic.co/t/excluding-bind-mounts/71509

  • Version: 5.1.2
  • Operating System: Debian 8 Linux 64bit
  • Steps to Reproduce:
    install and configure metricbeat to collect filesystem/fsstat data
    look at both installed Kibana dashboards, storage space is counted multiple times when bind mounts exist

Suggested solution:
Add a filesystem type field to the mapping, add a filter to the default config or hardcode exclude bind mounts (that would always make sense for fsstat as the total space is wrong with them).
@monicasarbu monicasarbu added the help wanted Indicates that a maintainer wants help on an issue or pull request label Feb 16, 2017
@ruflin ruflin added the module label Feb 26, 2018
@willemdh
Copy link

willemdh commented Apr 5, 2018

The fsstat module is really useless atm, please exclude mount points and subpaths by default.

@jsoriano jsoriano self-assigned this Apr 6, 2018
@exekias exekias removed the help wanted Indicates that a maintainer wants help on an issue or pull request label Apr 9, 2018
@jsoriano jsoriano mentioned this issue Apr 10, 2018
Merged
jsoriano added a commit to jsoriano/beats that referenced this issue Apr 16, 2018
@jsoriano
Metricbeat: Remove duplicated filesystems in system module
d0dfdeb 
Mountpoints whose device name is the same absolute path are considered
to be the same and are counted only once. The directory name used is
the shorter between them. This avoids duplication of filesystems as can
happen with bind mounts in Linux (elastic#3384).
exekias pushed a commit that referenced this issue Apr 16, 2018
@jsoriano @exekias
Metricbeat: Remove duplicated filesystems in system module (#6819)
272cad5 
* Metricbeat: Remove duplicated filesystems in system module

Mountpoints whose device name is the same absolute path are considered
to be the same and are counted only once. The directory name used is
the shorter between them. This avoids duplication of filesystems as can
happen with bind mounts in Linux (#3384).

* Metricbeat: Ignore nodev filesystems by default

In system module, when no filesystem type is set to be ignored, it
tries to make a sane guess. In systems with /proc/filesystems file it
ignores all devices marked as `nodev`.
@jsoriano
Copy link
Member

jsoriano commented Apr 16, 2018 •
edited
Loading

After #6819, each filesystem should appear only once even if it is mounted multiple times, if it is, only the shorter mount path is reported. Bind mounts won't be reported as it is assumed that the source/parent filesystem is also mounted and reported on its own.

Also, file systems of "virtual" filesystem types won't be reported by default (these types are autodiscovered when possible and added to filesystem.ignore_types).

I hope this helps to make these metricsets more useful by default, closing this by now.

@abraxxa
Copy link
Author

abraxxa commented Apr 16, 2018

Sounds great, thanks! In which version will this be included?

@ruflin
Copy link
Contributor

ruflin commented Apr 17, 2018

@abraxxa 6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsoriano jsoriano

Labels
enhancement Metricbeat Metricbeat module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jsoriano @ruflin @exekias @abraxxa @willemdh @monicasarbu