Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestream flaky tests #21489

Closed
jsoriano opened this issue Oct 2, 2020 · 1 comment · Fixed by #21625
Closed

filestream flaky tests #21489

jsoriano opened this issue Oct 2, 2020 · 1 comment · Fixed by #21625
Assignees
Labels
flaky-test Unstable or unreliable test cases. Team:Services (Deprecated) Label for the former Integrations-Services team

Comments

@jsoriano
Copy link
Member

jsoriano commented Oct 2, 2020

Flaky Test

Stack Trace

--- FAIL: TestFileWatchNewDeleteModified (0.00s)
    --- FAIL: TestFileWatchNewDeleteModified/two_modified_files (0.00s)
        fswatch_test.go:210: 
            	Error Trace:	fswatch_test.go:210
            	Error:      	Not equal: 
            	            	expected: input_logfile.FSEvent{NewPath:"path1", OldPath:"path1", Op:0x2, Info:filestream.testFileInfo{path:"path1", size:10, time:time.Time{wall:0xbfd5f554f5d9c463, ext:5008327320, loc:(*time.Location)(0xf80b40)}}}
            	            	actual  : input_logfile.FSEvent{NewPath:"path2", OldPath:"path2", Op:0x2, Info:filestream.testFileInfo{path:"path2", size:10, time:time.Time{wall:0xbfd5f554f5d9c463, ext:5008327320, loc:(*time.Location)(0xf80b40)}}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,7 +1,7 @@
            	            	 (input_logfile.FSEvent) {
            	            	- NewPath: (string) (len=5) "path1",
            	            	- OldPath: (string) (len=5) "path1",
            	            	+ NewPath: (string) (len=5) "path2",
            	            	+ OldPath: (string) (len=5) "path2",
            	            	  Op: (input_logfile.Operation) 2,
            	            	  Info: (filestream.testFileInfo) {
            	            	-  path: (string) (len=5) "path1",
            	            	+  path: (string) (len=5) "path2",
            	            	   size: (int64) 10,
            	Test:       	TestFileWatchNewDeleteModified/two_modified_files
        fswatch_test.go:210: 
            	Error Trace:	fswatch_test.go:210
            	Error:      	Not equal: 
            	            	expected: input_logfile.FSEvent{NewPath:"path2", OldPath:"path2", Op:0x2, Info:filestream.testFileInfo{path:"path2", size:10, time:time.Time{wall:0xbfd5f554f5d9c463, ext:5008327320, loc:(*time.Location)(0xf80b40)}}}
            	            	actual  : input_logfile.FSEvent{NewPath:"path1", OldPath:"path1", Op:0x2, Info:filestream.testFileInfo{path:"path1", size:10, time:time.Time{wall:0xbfd5f554f5d9c463, ext:5008327320, loc:(*time.Location)(0xf80b40)}}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1,7 +1,7 @@
            	            	 (input_logfile.FSEvent) {
            	            	- NewPath: (string) (len=5) "path2",
            	            	- OldPath: (string) (len=5) "path2",
            	            	+ NewPath: (string) (len=5) "path1",
            	            	+ OldPath: (string) (len=5) "path1",
            	            	  Op: (input_logfile.Operation) 2,
            	            	  Info: (filestream.testFileInfo) {
            	            	-  path: (string) (len=5) "path2",
            	            	+  path: (string) (len=5) "path1",
            	            	   size: (int64) 10,
            	Test:       	TestFileWatchNewDeleteModified/two_modified_files
FAIL
FAIL	github.com/elastic/beats/v7/filebeat/input/filestream	0.018s
@jsoriano jsoriano added flaky-test Unstable or unreliable test cases. Team:Services (Deprecated) Label for the former Integrations-Services team labels Oct 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@kvch kvch self-assigned this Oct 7, 2020
kvch added a commit that referenced this issue Oct 8, 2020
## What does this PR do?

Unit tests in for `fswatch.go` do not depend on the order of the returned events anymore.

Closes #21489
kvch added a commit to kvch/beats that referenced this issue Oct 8, 2020
## What does this PR do?

Unit tests in for `fswatch.go` do not depend on the order of the returned events anymore.

Closes elastic#21489

(cherry picked from commit 4754602)
kvch added a commit to kvch/beats that referenced this issue Oct 8, 2020
## What does this PR do?

Unit tests in for `fswatch.go` do not depend on the order of the returned events anymore.

Closes elastic#21489

(cherry picked from commit 4754602)
kvch added a commit that referenced this issue Oct 8, 2020
## What does this PR do?

Unit tests in for `fswatch.go` do not depend on the order of the returned events anymore.

Closes #21489

(cherry picked from commit 4754602)
kvch added a commit that referenced this issue Oct 8, 2020
## What does this PR do?

Unit tests in for `fswatch.go` do not depend on the order of the returned events anymore.

Closes #21489

(cherry picked from commit 4754602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Unstable or unreliable test cases. Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants