Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load the template depending on ES version #1740

Closed
monicasarbu opened this issue May 26, 2016 · 0 comments
Closed

Load the template depending on ES version #1740

monicasarbu opened this issue May 26, 2016 · 0 comments
Assignees
@tsg
Labels
enhancement in progress Pull request is currently in progress. libbeat

Comments

@monicasarbu
Copy link
Contributor

It was requested here:

May I suggest you to implement in libbeat a way to push the correct ES template file depending on the ES server.
I believe it should not be difficult to query the ES version and select xxx.template,json or xxx.template-es2x.json instead of having to configure it in the yaml file.
@tsg tsg self-assigned this Jul 6, 2016
@tsg tsg added the in progress Pull request is currently in progress. label Jul 6, 2016
@tsg tsg mentioned this issue Jul 8, 2016
Merged
tsg pushed a commit to tsg/beats that referenced this issue Jul 13, 2016
Load template by default, depending on the version
c08b36b 
This queries Elasticsearch for the version and choses between the
default template file (specified by the `template.path` option) and
the ES 2x version of the template file (specified by the new
`template.versions.2x.path` option).

There's also a change in the defaults. With all the template
options commented out, the code now loads the template. Previously,
the template loading was the default via the sample configs only.

I also did a small change in the output plugins API, now they receive
the beatname in a clean way.

Fixes elastic#1740.
ruflin pushed a commit that referenced this issue Jul 13, 2016
@tsg @ruflin
Load template by default, depending on the version (#1993)
787f45b 
This queries Elasticsearch for the version and choses between the
default template file (specified by the `template.path` option) and
the ES 2x version of the template file (specified by the new
`template.versions.2x.path` option).

There's also a change in the defaults. With all the template
options commented out, the code now loads the template. Previously,
the template loading was the default via the sample configs only.

I also did a small change in the output plugins API, now they receive
the beatname in a clean way.

Fixes #1740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsg tsg

Labels
enhancement in progress Pull request is currently in progress. libbeat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsg @monicasarbu