Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbn-version header might become stale #14481

Closed
jalvz opened this issue Nov 12, 2019 · 0 comments · Fixed by #14482
Closed

kbn-version header might become stale #14481

jalvz opened this issue Nov 12, 2019 · 0 comments · Fixed by #14482
Assignees
@jalvz

Comments

@jalvz
Copy link
Contributor

jalvz commented Nov 12, 2019

I believe that right now this is only an issue in apm-server, but non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e
@jalvz jalvz self-assigned this Nov 12, 2019
jalvz added a commit to jalvz/beats that referenced this issue Nov 12, 2019
@jalvz
Remove kbn-version header from requests to Kibana.
f237ecd 
Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes elastic#14481
@jalvz jalvz mentioned this issue Nov 12, 2019
Merged
jalvz added a commit that referenced this issue Nov 13, 2019
@jalvz
Remove kbn-version header from requests to Kibana. (#14482)
b608c61 
Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes #14481
jalvz added a commit to jalvz/beats that referenced this issue Nov 13, 2019
@jalvz
Remove kbn-version header from requests to Kibana. (elastic#14482)
f98efdd 
Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes elastic#14481
jalvz added a commit to jalvz/beats that referenced this issue Nov 13, 2019
@jalvz
Remove kbn-version header from requests to Kibana. (elastic#14482)
9b42206 
Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes elastic#14481
jalvz added a commit that referenced this issue Nov 13, 2019
@jalvz
Remove kbn-version header from requests to Kibana. (#14482) (#14494)
b110c7a 
Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes #14481
@jalvz jalvz mentioned this issue Nov 13, 2019
Closed
jalvz added a commit that referenced this issue Nov 19, 2019
@jalvz
Remove kbn-version header from requests to Kibana. (#14482) (#14493)
4db6283 
Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes #14481
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@jalvz
Remove kbn-version header from requests to Kibana. (elastic#14482) (e…
0831eec 
…lastic#14494)

Non-browser clients are expected to use only kbn-xsrf for CSRF protection, and not kbn-version.
kbn-version is problematic when Kibana is upgraded, since the version is only pinned at startup when libbeat establishes the connection.

See elastic/kibana@621bf0e

Fixes elastic#14481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jalvz jalvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove kbn-version header from requests to Kibana. jalvz/beats
1 participant
@jalvz