Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECS container fields for kubernetes #10926

Closed
jsoriano opened this issue Feb 25, 2019 · 7 comments · Fixed by #13884
Closed

Add ECS container fields for kubernetes #10926

jsoriano opened this issue Feb 25, 2019 · 7 comments · Fixed by #13884
Assignees
Labels

Comments

@jsoriano
Copy link
Member

jsoriano commented Feb 25, 2019

Kubernetes fields are not migrated to ECS, but from some of them we could extract some common fields:

  • kubernetes.container.id has the form runtime://id, we could extract container.runtime and container.id.
  • kubernetes.node.name could be copied to some general hostname-like field. (It could be covered by Report host metadata for Kubernetes logs #12790)
@jsoriano jsoriano added enhancement libbeat Metricbeat Metricbeat ecs Team:Integrations Label for the Integrations team labels Feb 25, 2019
@kaiyan-sheng
Copy link
Contributor

@jsoriano Thanks for creating this issue! Is this for 7.x?

@jsoriano
Copy link
Member Author

@kaiyan-sheng this would be nice to have soon, but not required for 7.0 as won't introduce breaking changes, this will only add new fields.

@ruflin
Copy link
Member

ruflin commented Mar 4, 2019

I remember discussing this with @exekias and there was something like: kubernetes.container.id could be different from the container.id but don't remember why anymore.

@jsoriano
Copy link
Member Author

jsoriano commented Mar 4, 2019

@ruflin yes, it is different, but we could maybe use it to extract the runtime and the id in the runtime.

@ruflin
Copy link
Member

ruflin commented Mar 4, 2019

SGTM

@alvarolobato alvarolobato added [zube]: Inbox discuss Issue needs further discussion. [zube]: Backlog and removed [zube]: Inbox labels Mar 4, 2019
@exekias exekias added Filebeat Filebeat and removed discuss Issue needs further discussion. labels Jul 4, 2019
@exekias
Copy link
Contributor

exekias commented Jul 4, 2019

Let's move this one forward, specially for container.id, as this is the field used by Infra UI to link logs & metrics. That will make docker metrics correlate with kubernetes logs, for instance

@kaiyan-sheng
Copy link
Contributor

I just realized I won't have the bandwidth to finish this for 7.5.0. Please feel free to pick it up and start working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants