-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat]Kubernetes: make state_container metricset ECS compliant #13884
[Metricbeat]Kubernetes: make state_container metricset ECS compliant #13884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the new fields need to be added to fields.yml?
@kaiyan-sheng thanks for taking a look. |
jenkins test this |
jenkins, test this |
jenkins, test this |
jenkins, test this |
manual testing:
Expected behaviour:
|
@sorantis @sgrodzicki @jasonrhodes Do we need any special handling for this change on the Metrics UI front, especially as we move toward 8.0 where the old fields are going to be removed? |
@simianhacker probably knows best |
We are looking at removing old fields here in 8.0. @simianhacker Could you confirm here that metrics UI is already switched to use the new field names? TIA!! |
@kaiyan-sheng after discussions in #23585 (comment) we will remove only |
@elastic/infra-monitoring-ui can someone confirm whether removal of this field will be a problem in kibana metrics UI? |
Move existing field
kubernetes.container.id
, atstate_container
kubernetes metricset, to the ECS compliant fields.Origin field contains a string prefixed by the container runtime, and suffixed with the container ID
New fields populated are
container.runtime
container.id
Previous field won't be removed until
8.0
elastic stack release.Fixes #10926