Skip to content

Commit

Permalink
Remove old reviewer notes (#6655)
Browse files Browse the repository at this point in the history
  • Loading branch information
dedemorton authored and ruflin committed Mar 27, 2018
1 parent 1f8d072 commit 867c23c
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 34 deletions.
4 changes: 0 additions & 4 deletions filebeat/docs/inputs/input-common-harvester-options.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,6 @@ decoding with filtering and multiline if you set the `message_key` option. This
can be helpful in situations where the application logs are wrapped in JSON
objects, as with like it happens for example with Docker.

// REVIEWERS: Is this setting required/necessary when the docker input is used?
// If so, what should I say? I'll need to conditionally code anything related
// to docker because this description shows up in multiple input types.

Example configuration:

[source,yaml]
Expand Down
13 changes: 0 additions & 13 deletions filebeat/docs/modules/kafka.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ file to override the default paths for logs:
-----


// REVIEWERS: I must be doing something wrong with the config settings. The
// above config works, but when I try to specify var.kafka_home, it doesn't
// seem to have any effect.


To specify the same settings at the command line, you use:

["source","sh",subs="attributes"]
Expand All @@ -66,14 +61,6 @@ include::../include/config-option-intro.asciidoc[]
[float]
==== `log` fileset settings

// REVIEWERS: I've added a description because this variable appears in the
// kafka.yml file. However, I don't understand how it works.

//*`var.kafka_home`*::

//The home path for Kafka. If this variable is not set, {beatname_uc} looks under
//`/opt`.

include::../include/var-paths.asciidoc[]


Expand Down
2 changes: 0 additions & 2 deletions filebeat/docs/modules/traefik.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ This module requires the
{elasticsearch-plugins}/ingest-user-agent.html[ingest-user-agent] and
{elasticsearch-plugins}/ingest-geoip.html[ingest-geoip] Elasticsearch plugins.

//REVIEWERS: Do we need to say anything else about compatibility here?

include::../include/running-modules.asciidoc[]

[float]
Expand Down
13 changes: 0 additions & 13 deletions filebeat/module/kafka/_meta/docs.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ file to override the default paths for logs:
-----


// REVIEWERS: I must be doing something wrong with the config settings. The
// above config works, but when I try to specify var.kafka_home, it doesn't
// seem to have any effect.


To specify the same settings at the command line, you use:

["source","sh",subs="attributes"]
Expand All @@ -61,12 +56,4 @@ include::../include/config-option-intro.asciidoc[]
[float]
==== `log` fileset settings

// REVIEWERS: I've added a description because this variable appears in the
// kafka.yml file. However, I don't understand how it works.

//*`var.kafka_home`*::

//The home path for Kafka. If this variable is not set, {beatname_uc} looks under
//`/opt`.

include::../include/var-paths.asciidoc[]
2 changes: 0 additions & 2 deletions filebeat/module/traefik/_meta/docs.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ This module requires the
{elasticsearch-plugins}/ingest-user-agent.html[ingest-user-agent] and
{elasticsearch-plugins}/ingest-geoip.html[ingest-geoip] Elasticsearch plugins.

//REVIEWERS: Do we need to say anything else about compatibility here?

include::../include/running-modules.asciidoc[]

[float]
Expand Down

0 comments on commit 867c23c

Please sign in to comment.