Incorporate review comments

elastic · Aug 26, 2020 · 5321417 · 5321417
1 parent 4f2897c
commit 5321417
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/metricbeat/helper/prometheus/prometheus.go b/metricbeat/helper/prometheus/prometheus.go
@@ -64,7 +64,7 @@ func NewPrometheusClient(base mb.BaseMetricSet) (Prometheus, error) {
 	}
 
 	http.SetHeaderDefault("Accept", acceptHeader)
-	http.SetHeader("Accept-Encoding", "gzip")
+	http.SetHeaderDefault("Accept-Encoding", "gzip")
 	return &prometheus{http, base.Logger()}, nil
 }
 
@@ -79,10 +79,12 @@ func (p *prometheus) GetFamilies() ([]*dto.MetricFamily, error) {
 	defer resp.Body.Close()
 
 	if resp.Header.Get("Content-Encoding") == "gzip" {
-		reader, err = gzip.NewReader(resp.Body)
+		greader, err := gzip.NewReader(resp.Body)
 		if err != nil {
 			return nil, err
 		}
+		defer greader.Close()
+		reader = greader
 	} else {
 		reader = resp.Body
 	}