Skip to content

Commit

Permalink
Removing format from test
Browse files Browse the repository at this point in the history
  • Loading branch information
ycombinator committed Jul 16, 2020
1 parent 9c34759 commit 2469c46
Showing 1 changed file with 10 additions and 36 deletions.
46 changes: 10 additions & 36 deletions libbeat/monitoring/report/elasticsearch/elasticsearch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,46 +21,20 @@ import (
"testing"

"github.com/stretchr/testify/require"

"github.com/elastic/beats/v7/libbeat/monitoring/report"
)

func TestMakeClientParams(t *testing.T) {
tests := map[string]struct {
format report.Format
params map[string]string
expected map[string]string
}{
"format_bulk": {
report.FormatBulk,
map[string]string{
"foo": "bar",
},
map[string]string{
"foo": "bar",
},
},
"format_xpack_monitoring_bulk": {
report.FormatXPackMonitoringBulk,
map[string]string{
"foo": "bar",
},
map[string]string{
"foo": "bar",
"system_id": "beats",
"system_api_version": "7",
},
},
var params, expected map[string]string
params = map[string]string{
"foo": "bar",
}
expected = map[string]string{
"foo": "bar",
}

for name, test := range tests {
t.Run(name, func(t *testing.T) {
params := makeClientParams(config{
Format: test.format,
Params: test.params,
})
p := makeClientParams(config{
Params: params,
})

require.Equal(t, test.expected, params)
})
}
require.Equal(t, expected, p)
}

0 comments on commit 2469c46

Please sign in to comment.