Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize CLOUD_PROVIDER config #289

Closed
basepi opened this issue Jun 30, 2020 · 6 comments
Closed

Standardize CLOUD_PROVIDER config #289

basepi opened this issue Jun 30, 2020 · 6 comments

Comments

@basepi
Copy link
Contributor

basepi commented Jun 30, 2020

Description of the issue

With the new cloud metadata support, we want to allow the user to reduce overhead of cloud provider "guessing" by setting the cloud provider manually, or disabling cloud provider metadata collection altogether.

What we are voting on

The new config option will be ELASTIC_APM_CLOUD_PROVIDER. The default will be "auto". If set to "none", the cloud metadata will not be collected at all. If set to "aws", "gcp", or "azure", the cloud metadata generation will only try to fetch metadata from the configured cloud provider. These should all be case-insensitive, though documentation should use lower-case values.

Feel free to use the same agent issue link from #256

Vote

Agent Yes No Indifferent N/A Link to agent issue
.NET
Go
Java
elastic/apm-agent-java#1264
Node.js
PHP
Python
elastic/apm-agent-python#822
Ruby

@elastic/apm-agent-devs

@eyalkoren
Copy link
Contributor

I am not sure why True and False are proper for a non-boolean option. I think auto-detect or all and none are better. Also, what about sticking to all-lowercase in documentation even if we make it case insensitive?

@axw
Copy link
Member

axw commented Jul 1, 2020

++ I'd also go with all strings: "auto" instead of True and "none" instead of False

@SergeyKleyman
Copy link
Contributor

I'd also go with "auto" or "auto-detect" instead of "True" and "none" instead of "False".

@mikker
Copy link
Contributor

mikker commented Jul 1, 2020

Agree on the all-string implementation. We'd have to convert from string anyway when set via ENV.

@basepi
Copy link
Contributor Author

basepi commented Jul 1, 2020

It's mostly a habit for me in python, since boolean operations are much faster than string comparisons.

I've updated the proposal to use auto and none. Please vote when convenient.

@basepi
Copy link
Contributor Author

basepi commented Jul 6, 2020

With all but .NET and Node voting yes, I'm going to call this proposal approved. We'll track the implementation in #256

@basepi basepi closed this as completed Jul 6, 2020
basepi added a commit to elastic/apm-agent-python that referenced this issue Jul 7, 2020
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this issue Oct 15, 2020
romulorosa pushed a commit to romulorosa/apm-agent-python that referenced this issue Oct 15, 2020
beniwohli pushed a commit to beniwohli/apm-agent-python that referenced this issue Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants