-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize CLOUD_PROVIDER config #289
Comments
I am not sure why |
++ I'd also go with all strings: |
I'd also go with |
Agree on the all-string implementation. We'd have to convert from string anyway when set via ENV. |
It's mostly a habit for me in python, since boolean operations are much faster than string comparisons. I've updated the proposal to use |
With all but .NET and Node voting yes, I'm going to call this proposal approved. We'll track the implementation in #256 |
Description of the issue
With the new cloud metadata support, we want to allow the user to reduce overhead of cloud provider "guessing" by setting the cloud provider manually, or disabling cloud provider metadata collection altogether.
What we are voting on
The new config option will be
ELASTIC_APM_CLOUD_PROVIDER
. The default will be"auto"
. If set to"none"
, the cloud metadata will not be collected at all. If set to"aws"
,"gcp"
, or"azure"
, the cloud metadata generation will only try to fetch metadata from the configured cloud provider. These should all be case-insensitive, though documentation should use lower-case values.Feel free to use the same agent issue link from #256
Vote
@elastic/apm-agent-devs
The text was updated successfully, but these errors were encountered: