-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable smoke tests in CI #8499
Enable smoke tests in CI #8499
Conversation
This pull request does not have a backport label. Could you fix it @amannocci? 🙏
NOTE: |
1639b42
to
9b114ca
Compare
🌐 Coverage report
|
[Made edit to issue description to add issue reference] |
This pull request is now in conflicts. Could you fix it @amannocci? 🙏
|
a3ae897
to
9de0a20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update this PR to use the newer scripts or introduce a test.sh
script which can call the other scripts.
📚 Go benchmark reportDiff with the
report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
This pull request is now in conflicts. Could you fix it @amannocci? 🙏
|
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
4db8ba4
to
b41641f
Compare
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
Signed-off-by: Adrien Mannocci <[email protected]>
ed74315
to
60688b8
Compare
Signed-off-by: Adrien Mannocci <[email protected]>
60688b8
to
14fe11a
Compare
Status
Tests |
Signed-off-by: Adrien Mannocci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Signed-off-by: Adrien Mannocci [email protected]
Motivation/summary
Checklist
apmpackage
have been made)For functional changes, consider:
How to test these changes
make smoketest/all
.Related issues
Refs #8303