Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable smoke tests in CI #8499

Merged
merged 19 commits into from
Jul 8, 2022
Merged

Enable smoke tests in CI #8499

merged 19 commits into from
Jul 8, 2022

Conversation

amannocci
Copy link
Contributor

@amannocci amannocci commented Jun 28, 2022

Signed-off-by: Adrien Mannocci [email protected]

Motivation/summary

  • Enable smoke tests in CI.
  • Support running individual smoke tests.
  • Discover smoke tests and run them in parallel.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Refs #8303

@amannocci amannocci self-assigned this Jun 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

This pull request does not have a backport label. Could you fix it @amannocci? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 28, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jun 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-08T13:27:11.695+0000

  • Duration: 27 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 4108
Skipped 13
Total 4121

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@amannocci amannocci force-pushed the feature/ci-smoke-tests branch from 1639b42 to 9b114ca Compare June 29, 2022 09:16
@apmmachine
Copy link
Contributor

apmmachine commented Jun 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (42/42) 💚
Files 91.96% (183/199) 👍
Classes 93.435% (427/457) 👍
Methods 89.08% (1085/1218) 👎 -0.082
Lines 76.845% (13325/17340) 👍 0.023
Conditionals 100.0% (0/0) 💚

@amannocci amannocci marked this pull request as ready for review June 29, 2022 09:28
@amannocci amannocci requested review from marclop and a team June 29, 2022 09:28
.ci/smoke-tests.groovy Outdated Show resolved Hide resolved
.ci/smoke-tests.groovy Show resolved Hide resolved
.ci/smoke-tests.groovy Outdated Show resolved Hide resolved
@cachedout
Copy link
Contributor

[Made edit to issue description to add issue reference]

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

This pull request is now in conflicts. Could you fix it @amannocci? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/ci-smoke-tests upstream/feature/ci-smoke-tests
git merge upstream/main
git push upstream feature/ci-smoke-tests

@amannocci amannocci force-pushed the feature/ci-smoke-tests branch from a3ae897 to 9de0a20 Compare July 5, 2022 11:04
@cachedout
Copy link
Contributor

Gentle bump for @marclop on a review when you're able, please. This should get you what you need for #8303

Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update this PR to use the newer scripts or introduce a test.sh script which can call the other scripts.

.gitignore Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@apmmachine
Copy link
Contributor

apmmachine commented Jul 6, 2022

📚 Go benchmark report

Diff with the main branch

name                                                                                            old time/op    new time/op    delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
CompressedRequestReader/gzip_sniff-12                                                             13.9µs ±56%    17.6µs ± 1%  +27.20%  (p=0.008 n=5+5)
CompressedRequestReader/deflate_content_encoding-12                                               17.0µs ± 1%    16.8µs ± 1%   -1.10%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
ModelIndexer/DefaultCompression-12                                                                10.5µs ±27%    13.7µs ±15%  +29.80%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                                  104µs ±52%     158µs ±28%  +52.51%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-event-type.ndjson-12           807ns ± 2%     794ns ± 1%   -1.59%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata-2.ndjson-12           577ns ± 0%     561ns ± 1%   -2.74%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata.ndjson-12             580ns ± 1%     563ns ± 1%   -3.05%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions_spans_rum_2.ndjson-12    2.29µs ± 1%    2.24µs ± 1%   -2.11%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/errors_2.ndjson-12                    30.4µs ± 3%    36.7µs ±16%  +20.44%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/errors_rum.ndjson-12                  7.61µs ± 8%    7.07µs ± 2%   -7.16%  (p=0.032 n=5+4)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-metadata-2.ndjson-12          1.56µs ± 2%    1.80µs ±11%  +15.52%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metadata.ndjson-12                    3.99µs ± 3%    4.19µs ± 5%   +4.92%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/minimal-service.ndjson-12             5.01µs ± 4%    6.12µs ±27%  +22.21%  (p=0.048 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans.ndjson-12          44.6µs ± 7%    59.5µs ±15%  +33.20%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum.ndjson-12      7.02µs ± 4%    7.37µs ± 2%   +4.97%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum_2.ndjson-12    6.88µs ± 2%    7.44µs ± 8%   +8.17%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-event.ndjson-12               7.90µs ± 7%    8.77µs ±13%  +10.97%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12          3.00µs ± 8%    3.44µs ± 6%  +14.79%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-metadata-2.ndjson-12          1.57µs ± 3%    1.73µs ± 6%  +10.38%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/minimal-service.ndjson-12             4.47µs ± 7%    4.79µs ± 4%   +7.02%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/span-links.ndjson-12                  4.63µs ± 3%    5.17µs ± 4%  +11.62%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/spans.ndjson-12                       37.7µs ±13%    44.3µs ± 8%  +17.70%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans_rum_2.ndjson-12    5.00µs ±11%    5.96µs ± 3%  +19.22%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/heavy.ndjson-12                       2.25ms ± 4%    2.46ms ± 5%   +9.42%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/metadata-null-values.ndjson-12        1.41µs ± 2%    1.52µs ± 6%   +7.91%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/optional-timestamps.ndjson-12         4.28µs ± 5%    4.48µs ± 4%   +4.59%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/spans.ndjson-12                       18.8µs ± 1%    19.2µs ± 1%   +2.10%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
AggregateTransaction-12                                                                           72.1ns ± 2%    70.7ns ± 1%   -1.93%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/nop_codec/10_events-12                                                                 31.2µs ± 8%    25.7µs ±23%  -17.81%  (p=0.032 n=5+5)
IsTraceSampled/unknown-12                                                                          364ns ± 4%     353ns ± 2%   -2.96%  (p=0.032 n=5+5)

name                                                                                            old alloc/op   new alloc/op   delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
CompressedRequestReader/gzip_sniff-12                                                             45.6kB ± 0%    45.7kB ± 0%   +0.14%  (p=0.024 n=5+5)
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-json-metadata.ndjson-12                                                  6.00kB ± 2%    6.23kB ± 2%   +3.74%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-json-event.ndjson-12          7.00kB ± 1%    6.91kB ± 0%   -1.23%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans.ndjson-12          57.0kB ± 1%    57.7kB ± 1%   +1.25%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12          6.68kB ± 1%    6.78kB ± 1%   +1.46%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old allocs/op  new allocs/op  delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/errors.ndjson-12                                                                    461 ± 0%       460 ± 0%   -0.22%  (p=0.029 n=4+4)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old speed      new speed      delta
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                               76.1MB/s ±38%  48.7MB/s ±34%  -35.97%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-event-type.ndjson-12         484MB/s ± 2%   492MB/s ± 1%   +1.60%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata-2.ndjson-12         756MB/s ± 0%   777MB/s ± 1%   +2.82%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata.ndjson-12           769MB/s ± 1%   793MB/s ± 1%   +3.15%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions_spans_rum_2.ndjson-12   488MB/s ± 1%   498MB/s ± 1%   +2.16%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/errors_rum.ndjson-12                 250MB/s ± 8%   268MB/s ± 2%   +7.46%  (p=0.032 n=5+4)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-metadata-2.ndjson-12         279MB/s ± 2%   243MB/s ±11%  -13.15%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metadata.ndjson-12                   311MB/s ± 3%   297MB/s ± 5%   -4.62%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans.ndjson-12         131MB/s ± 7%    99MB/s ±14%  -24.26%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum.ndjson-12     165MB/s ± 4%   157MB/s ± 2%   -4.79%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/transactions_spans_rum_2.ndjson-12   162MB/s ± 2%   151MB/s ± 8%   -7.25%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-event.ndjson-12             97.2MB/s ± 8%  87.8MB/s ±12%   -9.69%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12         196MB/s ± 8%   171MB/s ± 6%  -13.02%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-metadata-2.ndjson-12         278MB/s ± 4%   252MB/s ± 6%   -9.33%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/minimal-service.ndjson-12           95.2MB/s ± 7%  88.9MB/s ± 4%   -6.68%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/span-links.ndjson-12                 147MB/s ± 3%   132MB/s ± 4%  -10.39%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/spans.ndjson-12                      214MB/s ±12%   182MB/s ± 8%  -15.31%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans_rum_2.ndjson-12   225MB/s ±10%   188MB/s ± 3%  -16.48%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/heavy.ndjson-12                      178MB/s ± 4%   163MB/s ± 5%   -8.56%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/metadata-null-values.ndjson-12       374MB/s ± 2%   347MB/s ± 6%   -7.19%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/optional-timestamps.ndjson-12        240MB/s ± 5%   229MB/s ± 5%   -4.41%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/spans.ndjson-12                      427MB/s ± 1%   418MB/s ± 1%   -2.06%  (p=0.008 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

.ci/smoke-tests.groovy Outdated Show resolved Hide resolved
testing/smoke/basic_upgrade/standalone-major-managed.sh Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

This pull request is now in conflicts. Could you fix it @amannocci? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/ci-smoke-tests upstream/feature/ci-smoke-tests
git merge upstream/main
git push upstream feature/ci-smoke-tests

@amannocci amannocci force-pushed the feature/ci-smoke-tests branch from 4db8ba4 to b41641f Compare July 7, 2022 08:02
@amannocci amannocci force-pushed the feature/ci-smoke-tests branch 4 times, most recently from ed74315 to 60688b8 Compare July 7, 2022 16:10
@amannocci amannocci force-pushed the feature/ci-smoke-tests branch from 60688b8 to 14fe11a Compare July 7, 2022 17:03
@amannocci
Copy link
Contributor Author

amannocci commented Jul 7, 2022

Status

Tests

Signed-off-by: Adrien Mannocci <[email protected]>
@amannocci amannocci requested review from marclop and v1v July 7, 2022 17:17
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@amannocci amannocci merged commit c7ee437 into main Jul 8, 2022
@amannocci amannocci deleted the feature/ci-smoke-tests branch July 8, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants