-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't drop RUM unsampled transactions #6669
Conversation
e9e03eb
to
d896bce
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This is broken, moving back into draft for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far
* Don't drop RUM unsampled transactions * Revert to using global monitoring registry * Fix systemtest * Update comment * Fix systemtest even more * Update changelog (cherry picked from commit 8e63576)
* Don't drop RUM unsampled transactions * Revert to using global monitoring registry * Fix systemtest * Update comment * Fix systemtest even more * Update changelog (cherry picked from commit 8e63576) Co-authored-by: Andrew Wilkins <[email protected]>
Verified with 9bb5e4c: Ingested transactions that are both sampled and upsampled, the "normal" unsampled transactions are dropped:
GET traces-apm*/_search
{
"query": {
"match": {
"transaction.id": "85925e55b43f4341"
}
}
}
// ...returns no results. Ingested upsampled rum transactions: {"metadata":{"service":{"name":"apm-agent-js","version":"1.0.0","agent":{"name":"rum-js","version":"0.0.0"}},"network":{"connection":{"type":"5G"}}}}
{"transaction":{"sampled":false,"id":"611f4fa950f04632","type":"page-load","duration":643,"context":{"page":{"referer":"http://localhost:8000/test/e2e/","url":"http://localhost:8000/test/e2e/general-usecase/"}},"trace_id":"611f4fa950f04631aaaaaaaaaaaaaaaa","span_count":{"started":1},"experience":{"cls":1,"fid":2.0,"tbt":3.4,"ignored":5,"also":"ignored"}}}
{"span":{"name":"transaction","type":"transaction","start":0,"duration":643,"stacktrace":[{"abs_path":"http://localhost:8000/test/e2e/general-usecase/bundle.js.map","filename":"test/e2e/general-usecase/bundle.js.map","function":"<anonymous>","lineno":1,"colno":18},{"abs_path":"http://localhost:8000/test/e2e/general-usecase/bundle.js.map","filename":"~/test/e2e/general-usecase/bundle.js.map","function":"<anonymous>","lineno":1,"colno":18}],"context":{"http":{"url":"http://localhost:8000/test/e2e/general-usecase/span"}},"transaction_id":"611f4fa950f04631","parent_id":"611f4fa950f04631","trace_id":"611f4fa950f04631aaaaaaaaaaaaaaaa","id":"aaaaaaaaaaaaaaaa"}} GET traces-apm.rum*/_search
{
"query": {
"match": {
"transaction.id": "611f4fa950f04632"
}
}
} {
"took" : 127,
"timed_out" : false,
"_shards" : {
"total" : 1,
"successful" : 1,
"skipped" : 0,
"failed" : 0
},
"hits" : {
"total" : {
"value" : 1,
"relation" : "eq"
},
"max_score" : 1.7917595,
"hits" : [
{
"_index" : ".ds-traces-apm.rum-default-2021.12.21-000001",
"_id" : "rDP6230ByDpadNqDuU9C",
"_score" : 1.7917595,
"_source" : {
"agent" : {
"name" : "rum-js",
"version" : "0.0.0"
},
"data_stream.namespace" : "default",
"source" : {
"port" : 53042,
"ip" : "127.0.0.1"
},
"data_stream.type" : "traces",
"processor" : {
"name" : "transaction",
"event" : "transaction"
},
"url" : {
"path" : "/test/e2e/general-usecase/",
"original" : "http://localhost:8000/test/e2e/general-usecase/",
"scheme" : "http",
"port" : 8000,
"domain" : "localhost",
"full" : "http://localhost:8000/test/e2e/general-usecase/"
},
"network" : {
"connection" : {
"type" : "5G"
}
},
"observer" : {
"hostname" : "Marcs-MacBook-Pro-2.local",
"id" : "bf2a6d26-c5ed-4b41-a507-feab5b75c095",
"type" : "apm-server",
"ephemeral_id" : "fdeb69ec-dad9-4791-b23f-022c3948ec37",
"version" : "8.0.0",
"version_major" : 8
},
"trace" : {
"id" : "611f4fa950f04631aaaaaaaaaaaaaaaa"
},
"@timestamp" : "2021-12-21T15:53:00.481+08:00",
"ecs" : {
"version" : "1.12.0"
},
"service" : {
"name" : "apm-agent-js",
"version" : "1.0.0"
},
"data_stream.dataset" : "apm.rum",
"http" : {
"request" : {
"referrer" : "http://localhost:8000/test/e2e/"
}
},
"client" : {
"ip" : "127.0.0.1"
},
"event" : {
"agent_id_status" : "missing",
"ingested" : "2021-12-21T07:53:01Z",
"outcome" : "unknown"
},
"user_agent" : {
"original" : "curl/7.64.1",
"name" : "curl",
"device" : {
"name" : "Other"
},
"version" : "7.64.1"
},
"transaction" : {
"duration" : {
"us" : 643000
},
"id" : "611f4fa950f04632",
"span_count" : {
"started" : 1
},
"type" : "page-load",
"experience" : {
"fid" : 2,
"tbt" : 3.4,
"cls" : 1
}
},
"timestamp" : {
"us" : 1640073180481075
}
}
}
]
}
} |
Motivation/summary
The User Experience app in Kibana currently relies on transaction events only, and not transaction metrics. Store all RUM transaction events so the UX app can calculate statistics correctly.
Checklist
- [ ] Update package changelog.yml (only if changes toapmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
Related issues
Closes #6260