Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python system tests #6555

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Nov 9, 2021

Motivation/summary

Remove old Python-based system tests. The remaining tests are either redundant (already have Go equivalents), or are about to be irrelevant as we remove support for index/ingest management.

This change means that sample event documents will be frozen in time. We should come back to these and replace the formerly generated system test documents with documents from ~real applications, like we did for metrics in #6173.

Checklist

- [ ] Update CHANGELOG.asciidoc

  • Documentation has been updated

How to test these changes

Related issues

@axw axw added v8.0.0 backport-8.0 Automated backport with mergify labels Nov 9, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Nov 9, 2021

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-09T03:47:20.143+0000

  • Duration: 39 min 10 sec

  • Commit: 427fd36

Test stats 🧪

Test Results
Failed 2
Passed 6215
Skipped 19
Total 6236

Test errors 2

Expand to view the tests failures

Build and Test / System and Environment Tests / TestRUMXForwardedFor/data_streams_enabled – github.com/elastic/apm-server/systemtest
    Expand to view the error details

     Failed 
    

    Expand to view the stacktrace

     === RUN   TestRUMXForwardedFor/data_streams_enabled
        rum_test.go:70: context deadline exceeded
        server.go:193: log file: /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-6555/src/github.com/elastic/apm-server/systemtest/logs/TestRUMXForwardedFor_data_streams_enabled/apm-server
        --- FAIL: TestRUMXForwardedFor/data_streams_enabled (60.70s)
     
    

Build and Test / System and Environment Tests / TestRUMXForwardedFor – github.com/elastic/apm-server/systemtest
    Expand to view the error details

     Failed 
    

    Expand to view the stacktrace

     === RUN   TestRUMXForwardedFor
    --- FAIL: TestRUMXForwardedFor (64.57s)
     
    

Steps errors 2

Expand to view the steps failures

Run Linux tests
  • Took 15 min 27 sec . View more details here
  • Description: ./.ci/scripts/linux-test.sh
Compress
  • Took 0 min 0 sec . View more details here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

@axw
Copy link
Member Author

axw commented Nov 9, 2021

/test

@axw axw requested a review from a team November 9, 2021 03:48
@axw axw marked this pull request as ready for review November 9, 2021 03:48
Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@axw
Copy link
Member Author

axw commented Nov 9, 2021

Unrelated test failure

@axw axw merged commit 90be0b1 into elastic:master Nov 9, 2021
@axw axw deleted the remove-python-system-tests branch November 9, 2021 04:36
mergify bot pushed a commit that referenced this pull request Nov 9, 2021
(cherry picked from commit 90be0b1)

# Conflicts:
#	tests/Dockerfile
axw added a commit that referenced this pull request Nov 9, 2021
* Remove Python system tests (#6555)

(cherry picked from commit 90be0b1)

# Conflicts:
#	tests/Dockerfile

* Delete Dockerfile

Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.0 Automated backport with mergify test-plan-skip v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants