Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtest: update opentelemetry-go #6124

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

axw
Copy link
Member

@axw axw commented Sep 6, 2021

Motivation/summary

Update the opentelemetry-go SDK used in system tests. Using this will allow us to test recording of errors as span events, and their translation to Elastic APM's error model. The old version of opentelemetry-go we're using now does not adhere to the exception semantic conventions.

Currently blocked by open-telemetry/opentelemetry-go#2220

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Documentation has been updated

How to test these changes

N/A

Related issues

@apmmachine
Copy link
Contributor

apmmachine commented Sep 6, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-21T07:12:26.779+0000

  • Duration: 44 min 54 sec

  • Commit: 311b2a4

Test stats 🧪

Test Results
Failed 0
Passed 6113
Skipped 14
Total 6127

Trends 🧪

Image of Build Times

Image of Tests

@axw axw force-pushed the systemtest-update-otelgo branch from f9fbab2 to d3096f6 Compare September 21, 2021 03:01
@axw axw requested a review from a team September 21, 2021 03:52
@axw axw marked this pull request as ready for review September 21, 2021 03:52
@axw axw enabled auto-merge (squash) September 21, 2021 07:12
@axw axw merged commit 117ca87 into elastic:master Sep 21, 2021
mergify bot pushed a commit that referenced this pull request Sep 21, 2021
Default span status changed to Unset: open-telemetry/opentelemetry-go#2102

(cherry picked from commit 117ca87)

# Conflicts:
#	systemtest/go.mod
#	systemtest/go.sum
axw added a commit that referenced this pull request Sep 23, 2021
* systemtest: update opentelemetry-go (#6124)

Default span status changed to Unset: open-telemetry/opentelemetry-go#2102

(cherry picked from commit 117ca87)

# Conflicts:
#	systemtest/go.mod
#	systemtest/go.sum

* Fix merge conflicts, go mod tidy

Co-authored-by: Andrew Wilkins <[email protected]>
@marclop marclop added backport-skip Skip notification from the automated backport with mergify test-plan-skip labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan-skip v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants