Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce model.Trace #5983

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Introduce model.Trace #5983

merged 1 commit into from
Aug 24, 2021

Conversation

axw
Copy link
Member

@axw axw commented Aug 20, 2021

Motivation/summary

Introduce type model.Trace and field model.APMEvent.Trace, replacing {Error,Span,Transaction}.TraceID. This will make it more straightforward to include trace.id in log events, for #4715.

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Documentation has been updated

How to test these changes

Non-functional change.

Related issues

#4410
#4120
#4715

Introduce type model.Trace and field APMEvent.Trace,
replacing {Error,Span,Transaction}.TraceID.
@apmmachine
Copy link
Contributor

apmmachine commented Aug 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-23T13:59:09.844+0000

  • Duration: 42 min 7 sec

  • Commit: e81523e

Test stats 🧪

Test Results
Failed 0
Passed 5935
Skipped 14
Total 5949

Trends 🧪

Image of Build Times

Image of Tests

@axw axw merged commit 6754818 into elastic:master Aug 24, 2021
@axw axw deleted the model-trace-ids branch August 24, 2021 00:07
mergify bot pushed a commit that referenced this pull request Aug 24, 2021
Introduce type model.Trace and field APMEvent.Trace,
replacing {Error,Span,Transaction}.TraceID.

(cherry picked from commit 6754818)
axw added a commit that referenced this pull request Aug 24, 2021
Introduce type model.Trace and field APMEvent.Trace,
replacing {Error,Span,Transaction}.TraceID.

(cherry picked from commit 6754818)

Co-authored-by: Andrew Wilkins <[email protected]>
@marclop marclop added backport-skip Skip notification from the automated backport with mergify test-plan-skip labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan-skip v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants