[apmpackage] Remove duplicate input variable attributes #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with elastic/kibana#106535 Kibana manages most of the input variable attributes. Remove all attributes from the manifest except for the name, type, multi and default value.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
|
/test |
axw
approved these changes
Aug 23, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
* Starting with elastic/kibana#106535 Kibana manages most of the input variable attributes. Remove all attributes from the manifest except for the name, type, multi and default value. * Fix TLS settings (cherry picked from commit ccf6509)
axw
pushed a commit
that referenced
this pull request
Aug 30, 2021
* Starting with elastic/kibana#106535 Kibana manages most of the input variable attributes. Remove all attributes from the manifest except for the name, type, multi and default value. * Fix TLS settings (cherry picked from commit ccf6509) Co-authored-by: Silvia Mitter <[email protected]>
|
Verified with BC3. Confirmed defaults are still set, policy looks ok and can be edited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Starting with elastic/kibana#106535 Kibana manages most of the
input variable attributes. Remove all attributes from the manifest
except for the name, type, multi and default value.
Non-functional change
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
apm-serverfrom githubpackage-registryfrom github, and runmage build, create a0.4.0folder insidebuild/package-storage/packages/apm/and copyapm-server/apmpackage/apm/*(from the apm-server repo) into the package-registry folderbuild/package-storage/packages/apm/0.4.0/and rungo run .apm-integration-testingstart the test setup and point to the local registry./scripts/compose.py start master --no-apm-server --with-elastic-agent --package-registry-url=http://host.docker.internal:8080