apmpackage: copy full field hierarchy #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the full field hierarchy to the integration package, instead of just leaf fields. Copying only leaf fields means we miss inherited group properties such as `dynamic`. Set a default `dynamic` property for each data stream mapping.
axw
force-pushed
the
integration-dynamic-false
branch
from
173331a to
d4ba1ff
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
reviewed
Aug 16, 2021
simitt
approved these changes
Aug 16, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
Copy the full field hierarchy to the integration package, instead of just leaf fields. Copying only leaf fields means we miss inherited group properties such as `dynamic`. Set a default `dynamic` property for each data stream mapping. (cherry picked from commit 03d4907) # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Aug 16, 2021
* apmpackage: copy full field hierarchy (#5947) Copy the full field hierarchy to the integration package, instead of just leaf fields. Copying only leaf fields means we miss inherited group properties such as `dynamic`. Set a default `dynamic` property for each data stream mapping. (cherry picked from commit 03d4907) # Conflicts: # changelogs/head.asciidoc * Delete head.asciidoc Co-authored-by: Andrew Wilkins <[email protected]>
|
Tested with BC3 - works as expected with package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Fix integration package index template mappings by copying the full field hierarchy to the integration package, instead of just flattened leaf fields. Copying only leaf fields means we miss inherited group properties such as
dynamic.dynamicproperty for each data stream mappingecs.versionto base fieldsChecklist
- [ ] Documentation has been updatedHow to test these changes
-E apm-server.data_streams.enabled=true)Related issues
#5707