-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data_streams.wait_for_integration
#5928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
force-pushed
the
standalone-datastreams
branch
2 times, most recently
from
August 11, 2021 09:37
f3ed031
to
ef9cc9d
Compare
axw
force-pushed
the
standalone-datastreams
branch
from
August 11, 2021 09:38
ef9cc9d
to
d7bdf49
Compare
simitt
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't run it but changes look good.
/test |
1 task
axw
added a commit
that referenced
this pull request
Aug 12, 2021
* Add `data_streams.wait_for_integration` (#5928) (cherry picked from commit 114d7d6) # Conflicts: # beater/beater.go # changelogs/head.asciidoc * Delete head.asciidoc * Fix merge conflicts Co-authored-by: Andrew Wilkins <[email protected]>
Confirmed with BC3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add
apm-server.data_streams.wait_for_integration
config. When both this andapm-server.data_streams.enabled
are true, the server will wait at startup until the APM integration package is installed.For now this requires
apm-server.kibana
to be configured, and will query the Fleet API to query the integration package status. We should follow up with a parallel query to Elasticsearch (if configured) to check if the index templates have been created.Checklist
How to test these changes
apm-server.data_streams.enable=true
(wait_for_integration
defaults to true)Related issues
#5914