Makefile: always use .go_version #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run ./script/run_with_go_ver in the Makefile to force the use of the Go version defined in .go_version for all targets and subprocesses. This ensures also ensures we can build on machines that do not have Go installed already.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
|
Adding this to the test plan to verify that subsequent release-manager builds are built with the expected version of Go. |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 18, 2021
Run ./script/run_with_go_ver in the Makefile to force the use of the Go version defined in .go_version for all targets and subprocesses. This ensures also ensures we can build on machines that do not have Go installed already. # Conflicts: # Makefile
axw
added a commit
that referenced
this pull request
Feb 18, 2021
Run ./script/run_with_go_ver in the Makefile to force the use of the Go version defined in .go_version for all targets and subprocesses. This ensures also ensures we can build on machines that do not have Go installed already. # Conflicts: # Makefile
|
Checked printing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
The Makefile runs various Go commands as part of variable expansions, for example to identify the beats module and to determine $GOOS. This only works if Go is installed on the machine already.
To better support machines that do not have Go installed, and to avoid running builds with mixed versions of Go, run
./script/run_with_go_verin the Makefile to force the use of the Go version defined in .go_version for all targets, shell invocations, and subprocesses. This ensures also ensures we can build on machines that do not have Go installed already.How to test these changes
make, check apm-server is built with the appropriate version of GoRelated issues
None.