-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version template for package docs #4568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Codecov Report
@@ Coverage Diff @@
## master #4568 +/- ##
==========================================
+ Coverage 75.88% 75.91% +0.03%
==========================================
Files 161 161
Lines 9792 9792
==========================================
+ Hits 7431 7434 +3
+ Misses 2361 2358 -3
|
…server into version-template-package-docs
axw
approved these changes
Jan 13, 2021
15 tasks
axw
pushed a commit
to axw/apm-server
that referenced
this pull request
Feb 18, 2021
axw
added a commit
that referenced
this pull request
Feb 18, 2021
Co-authored-by: Juan Álvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
The package spec contemplates a
_dev
folder, ignored by Fleet, for any arbitrary data.We can use to contain the template for generating docs, so it is versioned and there are no clashes when once we have more than 1 package.
Checklist
I have considered changes for: