-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package settings and icon #4542
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
apmpackage/apm/0.1.0/docs/README.md
Outdated
@@ -7,6 +7,7 @@ The APM integration installs Elasticsearch templates and Ingest Node pipelines f | |||
When you add an APM integration to a policy, that policy will contain an `apm` input. | |||
If a policy contains an `apm` input, any Elastic Agent(s) set up with that policy will run locally an APM Server binary. | |||
You must configure your APM Agents to communicate with that APM Server. | |||
If you run Elastic Agent in Docker, make sure to configure the APM Server `host` accordingly if it needs to be accessed from outside. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this is not only for Docker, also when it should be reachable outside of localhost.
…server into add-package-settings-and-icon
Codecov Report
@@ Coverage Diff @@
## master #4542 +/- ##
==========================================
- Coverage 75.98% 75.89% -0.10%
==========================================
Files 161 161
Lines 9789 9789
==========================================
- Hits 7438 7429 -9
- Misses 2351 2360 +9
|
Tested with 7.11 BC1, using apm-integration-testing with a small patch to make
The integration shows up with the icon:
|
# Conflicts: # apmpackage/apm/0.1.0/agent/input/template.yml.hbs # apmpackage/apm/0.1.0/docs/README.md # apmpackage/apm/0.1.0/manifest.yml # apmpackage/docs/README.template.md
# Conflicts: # apmpackage/apm/0.1.0/agent/input/template.yml.hbs # apmpackage/apm/0.1.0/docs/README.md # apmpackage/apm/0.1.0/manifest.yml # apmpackage/docs/README.template.md Co-authored-by: Juan Álvarez <[email protected]>
# Conflicts: # apmpackage/apm/0.1.0/agent/input/template.yml.hbs # apmpackage/apm/0.1.0/docs/README.md # apmpackage/apm/0.1.0/manifest.yml # apmpackage/docs/README.template.md Co-authored-by: Juan Álvarez <[email protected]>
# Conflicts: # apmpackage/apm/0.1.0/_dev/docs/README.template.md # apmpackage/apm/0.1.0/agent/input/template.yml.hbs # apmpackage/apm/0.1.0/docs/README.md # apmpackage/apm/0.1.0/manifest.yml
# Conflicts: # apmpackage/apm/0.1.0/_dev/docs/README.template.md # apmpackage/apm/0.1.0/agent/input/template.yml.hbs # apmpackage/apm/0.1.0/docs/README.md # apmpackage/apm/0.1.0/manifest.yml Co-authored-by: Juan Álvarez <[email protected]>
Motivation/summary
This makes
host
andsecret_token
configurable, primarily for the Docker use case.While at it, it also adds the APM icon
Checklist
I have considered changes for:
How to test these changes
Related issues
Closes #4540
Partially implements #4495
Screenshots