Migrate more system tests to Go #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
simitt
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Removing the extra tests for apm-server.instrumentation is fine.
Just a nit - please remove the libbeat_instrumentation_enabled parts from the tests/system/config/apm-server.yml.j2
Codecov Report
@@ Coverage Diff @@
## master #4469 +/- ##
==========================================
+ Coverage 75.95% 75.97% +0.02%
==========================================
Files 161 161
Lines 9787 9787
==========================================
+ Hits 7434 7436 +2
+ Misses 2353 2351 -2
|
Done, thanks for the nudge |
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 15, 2020
* systemtest: migrate profiling tests to Go * systemtest: migrate remaining instrumentation * systemtest: migrate another sampling-related test * systemtest: migrate some API Key command tests * tests/system/config: drop instrumentation bits
simitt
added a commit
that referenced
this pull request
Dec 15, 2020
* systemtest: migrate profiling tests to Go * systemtest: migrate remaining instrumentation * systemtest: migrate another sampling-related test * systemtest: migrate some API Key command tests * tests/system/config: drop instrumentation bits Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Migrate more system tests to Go. With the instrumentation tests, I deleted the tests for deprecated instrumentation config, and only test the new libbeat instrumentation config.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
cd systemtest && go test -vRelated issues
None.