Only add data_stream.* fields when enabled #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
axw
force-pushed
the
data_streams_allocs
branch
from
bf7e48c to
a0857f9
Compare
Only add data_streams.* fields when apm-server.data_streams.enabled is true. This avoids allocations when the feature is disabled, which will be the default for some time yet.
axw
force-pushed
the
data_streams_allocs
branch
from
a0857f9 to
2376d26
Compare
simitt
approved these changes
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #4461 +/- ##
==========================================
- Coverage 76.06% 76.03% -0.04%
==========================================
Files 158 158
Lines 9782 9776 -6
==========================================
- Hits 7441 7433 -8
- Misses 2341 2343 +2
|
jalvz
pushed a commit
to jalvz/apm-server
that referenced
this pull request
Dec 10, 2020
Only add data_streams.* fields when apm-server.data_streams.enabled is true. This avoids allocations when the feature is disabled, which will be the default for some time yet.
axw
added a commit
that referenced
this pull request
Dec 14, 2020
Only add data_streams.* fields when apm-server.data_streams.enabled is true. This avoids allocations when the feature is disabled, which will be the default for some time yet. Co-authored-by: Andrew Wilkins <[email protected]>
|
This was an internal optimization, no user facing change - nothing to test manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Only add
data_stream.*fields whenapm-server.data_streams.enabledis
true. This avoids allocations when the feature is disabled, which will bethe default for some time yet.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
make testRelated issues
Closes #4460