Move APM-specific template defaults to idxmgmt #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move APM-specific `setup.template.settings` defaults away from using config overrides, and add the logic to the idxmgmt package. Similarly drop `logging.files.rotateeverbytes`, as we were setting what is already the default defined by libbeat. Now when you run `apm-server export config`, these defaults do not show up at all. The relevant system tests have been migrated to Go, and the expectations updated to match the change in behaviour. We customise `logging.metrics.enabled`, and there is no other way to change the default before it is interpreted by libbeat, so it remains in config overrides for now.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
simitt
approved these changes
Nov 30, 2020
Not sure why that happened...
axw
added a commit
to axw/apm-server
that referenced
this pull request
Dec 14, 2020
* Move APM-specific template defaults to idxmgmt Move APM-specific `setup.template.settings` defaults away from using config overrides, and add the logic to the idxmgmt package. Similarly drop `logging.files.rotateeverbytes`, as we were setting what is already the default defined by libbeat. Now when you run `apm-server export config`, these defaults do not show up at all. The relevant system tests have been migrated to Go, and the expectations updated to match the change in behaviour. We customise `logging.metrics.enabled`, and there is no other way to change the default before it is interpreted by libbeat, so it remains in config overrides for now.
axw
added a commit
that referenced
this pull request
Dec 14, 2020
* Move APM-specific template defaults to idxmgmt Move APM-specific `setup.template.settings` defaults away from using config overrides, and add the logic to the idxmgmt package. Similarly drop `logging.files.rotateeverbytes`, as we were setting what is already the default defined by libbeat. Now when you run `apm-server export config`, these defaults do not show up at all. The relevant system tests have been migrated to Go, and the expectations updated to match the change in behaviour. We customise `logging.metrics.enabled`, and there is no other way to change the default before it is interpreted by libbeat, so it remains in config overrides for now.
|
Tested with BC1 - no template related config is shown; templates in ES show the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Move APM-specific
setup.template.settingsdefaultsaway from using config overrides, and add the logic
to the idxmgmt package.
Similarly drop
logging.files.rotateeverbytes, aswe were setting what is already the default defined
by libbeat.
Now when you run
apm-server export config, thesedefaults do not show up at all. The relevant system
tests have been migrated to Go, and the expectations
updated to match the change in behaviour.
We customise
logging.metrics.enabled, and thereis no other way to change the default before it is
interpreted by libbeat, so it remains in config
overrides for now.
Checklist
I have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
apm-server export configshould not show any template configapm-serverand check that it sets up templates as expected, including setting the maximum number of fields to 2000.Related issues
Pulled out of #4449
This is necessary before we can properly warn when data streams and template setup are both configured.