-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beater: telemetry for tail-based sampling config #4360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4360 +/- ##
==========================================
+ Coverage 79.67% 79.71% +0.03%
==========================================
Files 161 162 +1
Lines 8983 9173 +190
==========================================
+ Hits 7157 7312 +155
- Misses 1826 1861 +35
|
jalvz
approved these changes
Oct 28, 2020
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Oct 29, 2020
* beater: telemetry for tail-based sampling config
axw
added a commit
to axw/apm-server
that referenced
this pull request
Dec 10, 2020
* beater: telemetry for tail-based sampling config
axw
added a commit
that referenced
this pull request
Dec 10, 2020
Tested with BC1 - works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add some basic telemetry for tail-sampling config: if it's enabled, and the number of policies defined.
Checklist
I have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)How to test these changes
apm-server.sampling.tail.enabled: false
in abeats_state
monitoring doc.apm-server.sampling.tail.enabled: true
andapm-server.sampling.tail.policies: 2
in abeats_state
monitoring doc.Related issues
#4185