Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beater: telemetry for tail-based sampling config #4360

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

axw
Copy link
Member

@axw axw commented Oct 28, 2020

Motivation/summary

Add some basic telemetry for tail-sampling config: if it's enabled, and the number of policies defined.

Checklist

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)

How to test these changes

  1. Run apm-server with monitoring enabled, and without tail-sampling enabled: you should see apm-server.sampling.tail.enabled: false in a beats_state monitoring doc.
  2. Run apm-server with monitoring enabled, and tail-sampling enabled with two policies: you should see apm-server.sampling.tail.enabled: true and apm-server.sampling.tail.policies: 2 in a beats_state monitoring doc.

Related issues

#4185

@apmmachine
Copy link
Contributor

apmmachine commented Oct 28, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4360 updated]

  • Start Time: 2020-10-29T01:05:55.533+0000

  • Duration: 56 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 4376
Skipped 145
Total 4521

Steps errors 2

Expand to view the steps failures

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-29T01:22:36.464+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-29T01:36:05.010+0000

    • log

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #4360 into master will increase coverage by 0.03%.
The diff coverage is 79.61%.

@@            Coverage Diff             @@
##           master    #4360      +/-   ##
==========================================
+ Coverage   79.67%   79.71%   +0.03%     
==========================================
  Files         161      162       +1     
  Lines        8983     9173     +190     
==========================================
+ Hits         7157     7312     +155     
- Misses       1826     1861      +35     
Impacted Files Coverage Δ
beater/beater.go 61.45% <0.00%> (-0.85%) ⬇️
beater/config/sampling.go 84.61% <ø> (-0.57%) ⬇️
model/modeldecoder/v2/model.go 100.00% <ø> (ø)
x-pack/apm-server/main.go 0.00% <0.00%> (ø)
beater/telemetry.go 83.33% <50.00%> (-1.67%) ⬇️
sourcemap/mapper.go 68.18% <63.15%> (-31.82%) ⬇️
model/modeldecoder/v2/model_generated.go 70.40% <71.95%> (-0.01%) ⬇️
processor/stream/processor.go 75.63% <77.77%> (-0.90%) ⬇️
x-pack/apm-server/sampling/processor.go 79.62% <89.09%> (+3.50%) ⬆️
x-pack/apm-server/sampling/groups.go 93.00% <91.35%> (+6.43%) ⬆️
... and 12 more

@axw axw merged commit b670235 into elastic:master Oct 29, 2020
@axw axw deleted the tbs-config-telemetry branch October 29, 2020 02:07
@axw axw mentioned this pull request Oct 29, 2020
8 tasks
simitt pushed a commit to simitt/apm-server that referenced this pull request Oct 29, 2020
* beater: telemetry for tail-based sampling config
axw added a commit to axw/apm-server that referenced this pull request Dec 10, 2020
* beater: telemetry for tail-based sampling config
axw added a commit that referenced this pull request Dec 10, 2020
* beater: telemetry for tail-based sampling config
@simitt simitt self-assigned this Dec 23, 2020
@simitt
Copy link
Contributor

simitt commented Dec 23, 2020

Tested with BC1 - works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants